-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 (go/v4): Align webhook suite test with controller's suite test #4449
🐛 (go/v4): Align webhook suite test with controller's suite test #4449
Conversation
Hi @mateusoliveira43. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@camilamacedo86 will undo change to
Will add more info to PR description |
0c36daf
to
d540c85
Compare
docs/book/src/cronjob-tutorial/testdata/project/internal/controller/suite_test.go
Outdated
Show resolved
Hide resolved
Can you rebase it with the master and ensure that you have what was changed and why in the description? |
d540c85
to
f645d9b
Compare
@camilamacedo86 updated |
docs/book/src/cronjob-tutorial/testdata/project/internal/webhook/v1/webhook_suite_test.go
Show resolved
Hide resolved
/ok-to-test |
/overwrite pull-kubebuilder-e2e-k8s-1-32-0 |
Signed-off-by: Mateus Oliveira <[email protected]>
f645d9b
to
c122bee
Compare
/overwrite pull-kubebuilder-e2e-k8s-1-32-0 |
Thank you a lot for check this one 🥇 Let's move forward with this one /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, mateusoliveira43 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/overwrite pull-kubebuilder-e2e-k8s-1-32-0 |
/override pull-kubebuilder-e2e-k8s-1-32-0 |
@camilamacedo86: Overrode contexts on behalf of camilamacedo86: pull-kubebuilder-e2e-k8s-1-32-0 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Enable conversion webhooks for webhook
suite_test.go
envtest
by usingk8s.io/client-go/kubernetes/scheme
instead of creating new scheme (this also already done in controllersuite_test.go
)k8s.io/client-go/kubernetes/scheme
instead ofk8s.io/apimachinery/pkg/runtime
.