Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force line endings on *.sh files #31

Merged
merged 1 commit into from
Apr 3, 2021
Merged

Force line endings on *.sh files #31

merged 1 commit into from
Apr 3, 2021

Conversation

djfrmd
Copy link
Contributor

@djfrmd djfrmd commented Apr 1, 2020

Fix line endings for windows users. Do not allow user core.autocrlf to
change the line endings for *.sh files. This will fix issues building
container by removing the line endings on the shebang of the copied bash
files.

Users may need to delete all *.sh files, and then use git restore to update checked out files (another option for those that don't have changes is to delete and then clone the repo).

Fix line endings for windows users. Do not allow user core.autocrlf to
change the line endings for *.sh files. This will fix issues building
container by removing the line endings on the shebang of the copied bash
files.
@djfrmd
Copy link
Contributor Author

djfrmd commented Apr 1, 2020

This seemed to open a new issue, this commit is to resolve #30

@jbeda jbeda merged commit 47d6ea6 into kubernetes-up-and-running:master Apr 3, 2021
@jbeda
Copy link
Member

jbeda commented Apr 3, 2021

Thanks for this! Sorry it took me almost a year to merge it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants