Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update information about CronJob's unsupported time zone field #49327

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Jan 7, 2025

Description

This is accompanying the change from kubernetes/kubernetes#129510 which entirely forbids CRON_TZ and TZ variables in .spec.schedule of a cronjob.

/hold
for the k8s PR to merge first

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Jan 7, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 7, 2025
Copy link

netlify bot commented Jan 7, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 5f6ae8e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/679235b5378886000843c4fc
😎 Deploy Preview https://deploy-preview-49327--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 23, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign katcosgrove for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Contributor Author

soltysh commented Jan 23, 2025

We've decided not to land kubernetes/kubernetes#129510 at all, but we want to change the docs, entirely removing the wording about what is allowed with regards to TZ and CRON_TZ - the general stand is that it's not never was officially supported.

@soltysh
Copy link
Contributor Author

soltysh commented Jan 23, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2025
@soltysh
Copy link
Contributor Author

soltysh commented Jan 23, 2025

/assign @sftim
since you looked at kubernetes/kubernetes#129510

[warning](/blog/2020/09/03/warnings/) to the client.
is **not officially supported** (and never has been). If you try to set a schedule
that includes `TZ` or `CRON_TZ` timezone specification, Kubernetes will fail to
create or update the resource with a validation error. Users are encouraged to use
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style nit:

Suggested change
create or update the resource with a validation error. Users are encouraged to use
create or update the resource with a validation error. You should specify time zones using the

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should mention that the early beta CronJob API didn't include that enforcement, so that people can understand how come they have TZ set in their CronJob.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants