-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update information about CronJob's unsupported time zone field #49327
base: main
Are you sure you want to change the base?
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Maciej Szulik <[email protected]>
2294aa3
to
5f6ae8e
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We've decided not to land kubernetes/kubernetes#129510 at all, but we want to change the docs, entirely removing the wording about what is allowed with regards to |
/hold cancel |
/assign @sftim |
[warning](/blog/2020/09/03/warnings/) to the client. | ||
is **not officially supported** (and never has been). If you try to set a schedule | ||
that includes `TZ` or `CRON_TZ` timezone specification, Kubernetes will fail to | ||
create or update the resource with a validation error. Users are encouraged to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style nit:
create or update the resource with a validation error. Users are encouraged to use | |
create or update the resource with a validation error. You should specify time zones using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should mention that the early beta CronJob API didn't include that enforcement, so that people can understand how come they have TZ
set in their CronJob.
Description
This is accompanying the change from kubernetes/kubernetes#129510 which entirely forbids
CRON_TZ
andTZ
variables in.spec.schedule
of a cronjob./hold
for the k8s PR to merge first