Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move versioncheck from kubescape to backend #23

Merged
merged 4 commits into from
Mar 5, 2024
Merged

move versioncheck from kubescape to backend #23

merged 4 commits into from
Mar 5, 2024

Conversation

matthyx
Copy link
Contributor

@matthyx matthyx commented Mar 5, 2024

No description provided.

@matthyx matthyx requested a review from dwertent March 5, 2024 10:17
matthyx added 3 commits March 5, 2024 11:20
@matthyx
move versioncheck from kubescape to backend
c223eb4 
Signed-off-by: Matthias Bertschy <[email protected]>
@matthyx
update version check URL
ed46422 
Signed-off-by: Matthias Bertschy <[email protected]>
@matthyx
add info to version check request
832d123 
Signed-off-by: Matthias Bertschy <[email protected]>
@matthyx
fix test
1cace43 
Signed-off-by: Matthias Bertschy <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

Pull Request Test Coverage Report for Build 8154938037

Details

  • 33 of 118 (27.97%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.2%) to 60.411%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/versioncheck/versioncheck.go 33 118 27.97%
Totals Coverage Status
Change from base Build 7537617078: -2.2%
Covered Lines: 1146
Relevant Lines: 1897
💛 - Coveralls

@matthyx matthyx marked this pull request as ready for review March 5, 2024 10:50
amirmalka
amirmalka reviewed Mar 5, 2024
View reviewed changes
pkg/versioncheck/versioncheck.go

var BuildNumber string
var Client string
var LatestReleaseVersion string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we need these as global vars or as part of the handler.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate these, but I just lift and moved the code there

@matthyx matthyx merged commit 61d65ac into main Mar 5, 2024
3 checks passed
@matthyx matthyx deleted the daily branch March 5, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amirmalka amirmalka amirmalka approved these changes

@dwertent dwertent Awaiting requested review from dwertent

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthyx @amirmalka