[pull] master from kubernetes-sigs:master #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…core-types ✨ Add Support for Scaffolding Webhooks for Core Types
… properly generate the sample for cert-manager. - Allowing the domain be empty since some scenarios this value might not be required - Use `io` as the domain to fix the scaffold sample for cert-manager and update the example in the documentation.
…ernal-types 🐛 fix support for external types by allowing the domain be empty, and properly generate the sample for cert-manager.
fix GoReleaser by adding permission to write content We found an issue to publish the assets when we are trying to publish the release 4.3.0. Therefore, we are adding the content permission to verify if the issue can be solved within
…ter branch - Updated the Quick Start guide to include details on how to work with the master branch. - Linked to the contributing guide for building Kubebuilder locally.
We generate a sample API in the testdata directory using the DeployImage plugin. However, the flag previously contained incorrect information regarding the image that should be used. This fix ensures the correct image is referenced.
…sed installation Enhance e2e test coverage by including scenarios that verify webhook functionality when the installation is performed via the installer.
🌱 Fix incorrect image reference for DeployImage plugin in test data
🌱 e2e tests: increase coverage by validating webhooks with installer-based installation
…v4.3.0 in the doc sample used - Bump sigs.k8s.io/kubebuilder/v4 from 4.2.0 to 4.3.0 in /docs/book/src/simple-external-plugin-tutorial/testdata/sampleexternalplugin/v1. - Resolve compatibility by moving tests to GitHub Actions to use source code directly. - Remove external plugin e2e tests, as they do not run against a cluster, reducing complexity without testing across all k8s versions.
…ugin-tests 🌱 Fix simplify external plugin tests
Upgrade controller-runtime from v0.19.0 to v0.19.1
Upgrade kustomize version from v5.4.3 to v5.5.0
- Upgraded golangci-lint from v1.59 to v1.61. - Fixed issues flagged by new lint rules in v1.61: - Resolved `comment-spacings` errors in api.go by adding spaces after `//` delimiters. - Addressed `govet` error by formatting non-constant strings in `fmt.Errorf`. - Updated `staticcheck` issues in resource.go by replacing `fmt.Errorf` with `errors.New` for static error messages. - Deprecated the `exportloopref` linter, replaced by `copyloopvar` for Go 1.22+.
✨ Upgrade golangci-lint from v1.59 to v1.61 and resolve new lint issues
… action (#4237) Upgrade GoReleaser version from v2.1.0 to v2.3.2 used in the GitHub action
Upgrade controller-gen version used to generate documentation The documenation for the markers are generated automatic. The project currently scaffold solutions using controller-gen 0.16.4 therefore the documentation should either be generated using this version
Added comments to `NewScaffoldCommand` to clarify that the `kubebuilder alpha generate` command is designed for Kubebuilder’s internal use only. The updated go documentation explains that importing this command into other projects is not supported, as it relies on Kubebuilder-specific configurations, key mappings, and plugins, which may not be applicable to other setups. Projects that use Kubebuilder as a library and require similar functionality should implement a custom solution for compatibility with their specific configurations and plugins.
- Integrated SBOM generation in GoReleaser using Syft to produce CycloneDX SBOMs. - Updated GitHub Actions workflow to install Syft, enabling automated SBOM creation on release. - This enhancement is part of ongoing efforts to align with the EU Cyber Resilience Act, ensuring transparency and security in our software supply chain.
- Remove configurations for deprecated branches no longer in use - Change schedule to perform checks daily for up-to-date dependency management - Ensure dependencies in sample projects are properly included in checks
…ed page The Quick Start now has a note that links its page. The info is too verbose and might be not helpful and it is scaring for those that are looking for a Quick Start
Signed-off-by: Thiha Min Thant <[email protected]>
📖 Resolve navigation bar CSS issue and sidebar toggle functionality.
🌱 Update Dependabot configuration
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.34.2 to 1.35.0. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.34.2...v1.35.0) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…sample (#4273) The go.mod check for sample configuration helps us identify potential required bumps. However, note that go.mod is often updated by controller-runtime, so we can't manually change certain dependencies. Additionally, we only need to check one sample project—there’s no need to duplicate efforts by opening the same PR across all samples.
…ithub.com/onsi/gomega-1.35.0 🌱 Bump github.com/onsi/gomega from 1.34.2 to 1.35.0
fix: tutorial test docs Signed-off-by: Mateus Oliveira <[email protected]>
This commit change the action in order to use a matrix to validate all samples under testdata
🌱improve Ginkgo/Gomega test style
🌱 (ci): Improve GitHub Action to linter samples under testdata
fix: standardize scaffold test suites Signed-off-by: Mateus Oliveira <[email protected]>
Upgrade golangci-lint from v1.61.0 to v1.62.2
📖 (doc): Add "Kubebuilder Project Roadmap 2025"
Upgrade scaffolds to use go 1.23
e2e - ensure that error from command is checked
Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.22.1 to 2.22.2. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.22.1...v2.22.2) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
fix: use Go version from go.mod file in CI Signed-off-by: Mateus Oliveira <[email protected]>
e2e tests improve assertions by simplify style of checks
Upgrade controller-gen from v0.16.5 to v0.17.0
Add lint-config target to validate config and fix issues faced Fix golangci-lint config schema errors: corrected invalid govet fieldalignment Co-Author: Mateus Oliveira <[email protected]>
enable lint check empty-block and fix issues
Enable var-naming lint and fix issues for Kubebuilder CLI
…4461) Enable if-return linter check and fix issues for Kubebuilder CLI
…onfig (#4462) (go/v4): Add new makefile target to check and validate the linter config Co-Author: Mateus Oliveira <[email protected]>
Enable the lint to check exported methods and fix issues
…ite tests for webhooks and controllers (#4466) fix: add schemas prior to envtest start Signed-off-by: Mateus Oliveira <[email protected]>
Fix linter error `nilness: impossible condition: nil != nil (govet)`
```
golangci-lint run
pkg/plugins/golang/v4/scaffolds/edit.go:60:9: nilness: impossible condition: nil != nil (govet)
if err != nil && s.multigroup != s.config.IsMultiGroup() {
^
make: *** [lint] Error 1
```
Signed-off-by: Mateus Oliveira <[email protected]>
fix: simplify E2E Book Samples job Signed-off-by: Mateus Oliveira <[email protected]>
fix: remaining Go upgrades Signed-off-by: Mateus Oliveira <[email protected]>
fix: remove unused nolint comments Signed-off-by: Mateus Oliveira <[email protected]>
Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.28.0 to 0.29.0. - [Release notes](https://github.com/golang/tools/releases) - [Commits](golang/tools@v0.28.0...v0.29.0) --- updated-dependencies: - dependency-name: golang.org/x/tools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…caffold code (#4471) fix: remove unnecessary make manifest and make generate in E2E scaffold code Signed-off-by: Mateus Oliveira <[email protected]>
Bumps [github.com/spf13/afero](https://github.com/spf13/afero) from 1.11.0 to 1.12.0. - [Release notes](https://github.com/spf13/afero/releases) - [Commits](spf13/afero@v1.11.0...v1.12.0) --- updated-dependencies: - dependency-name: github.com/spf13/afero dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Upgrade controller-runtime v0.19.1 to v0.19.4
…m chart values (#4451) (helm/v1alpha1) - fix webhook generation by removing data from helm chart values This commit changes the code implementation so that the webhook values in the helm chart are not generated. Instead, only expose the values to enable or not webhooks
Add helm-plugin to the summary of available plugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )