Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VM and VMI persistent IPs e2e tests #20

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Add VM and VMI persistent IPs e2e tests #20

merged 3 commits into from
Jun 17, 2024

Conversation

qinqon
Copy link
Collaborator

@qinqon qinqon commented Jun 7, 2024 •
edited
Loading

Add scripts to start the ovn-k kind cluster and also add the following e2e tests:

  • Check persistent IPs are kept for
    • vm live migration
    • vm restart
    • vmi live migration
  • Check IPAMClaims get garbage collected after VM and VMI deletion.

@qinqon qinqon force-pushed the e2e branch 5 times, most recently from 1b16199 to aa58640 Compare June 10, 2024 09:44
@qinqon qinqon marked this pull request as ready for review June 10, 2024 09:45
@qinqon qinqon requested a review from maiqueb June 10, 2024 09:47
@qinqon qinqon force-pushed the e2e branch 6 times, most recently from 9f1822c to 09eeb5b Compare June 10, 2024 10:35
@qinqon qinqon changed the title E2e Add VM and VMI persistent IPs e2e tests Jun 10, 2024
maiqueb
maiqueb reviewed Jun 10, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@qinqon qinqon force-pushed the e2e branch 8 times, most recently from e71f7d6 to f99e989 Compare June 10, 2024 12:36
@qinqon qinqon requested a review from maiqueb June 10, 2024 12:36
@qinqon qinqon force-pushed the e2e branch 4 times, most recently from 2f56d62 to 3e08f16 Compare June 11, 2024 07:42
maiqueb
maiqueb requested changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of my requests are nits.

Thanks for this PR. Really good.

Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
hack/cluster.sh Outdated Show resolved Hide resolved
hack/cluster.sh Outdated Show resolved Hide resolved
test/e2e/persistentips_test.go Show resolved Hide resolved
test/e2e/persistentips_test.go Outdated Show resolved Hide resolved
test/e2e/persistentips_test.go Show resolved Hide resolved
test/e2e/persistentips_test.go Outdated Show resolved Hide resolved
test/e2e/persistentips_test.go Show resolved Hide resolved
maiqueb
maiqueb reviewed Jun 11, 2024
View reviewed changes
test/env/migration.go Outdated Show resolved Hide resolved
@qinqon qinqon requested a review from maiqueb June 11, 2024 10:41
maiqueb
maiqueb reviewed Jun 11, 2024
View reviewed changes
test/env/status.go Outdated Show resolved Hide resolved
@qinqon qinqon requested a review from maiqueb June 11, 2024 13:00
@qinqon qinqon force-pushed the e2e branch 2 times, most recently from 9a8f232 to 29496c5 Compare June 11, 2024 13:32
maiqueb
maiqueb previously approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@qinqon
Copy link
Collaborator Author

qinqon commented Jun 11, 2024

/cc @oshoval

Can you take a look ?

oshoval
oshoval reviewed Jun 16, 2024
View reviewed changes
Copy link
Collaborator

@oshoval oshoval left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice
PR desc typo "vm restasrt"

EDIT - about CNAO stuff, i will do it on a follow-up unless you want to do the important ones already
(only #20 (comment) is the most important)

.gitignore Show resolved Hide resolved
Makefile Show resolved Hide resolved
hack/cluster.sh Show resolved Hide resolved
hack/cluster.sh Show resolved Hide resolved
hack/cluster.sh Show resolved Hide resolved
hack/cluster.sh Show resolved Hide resolved
test/e2e/persistentips_test.go Show resolved Hide resolved
test/env/compose.go Show resolved Hide resolved
oshoval
oshoval reviewed Jun 16, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@oshoval
Copy link
Collaborator

oshoval commented Jun 17, 2024

once it is merged, we would need please a new tag, so we can consume it on CNAO

oshoval
oshoval reviewed Jun 17, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
qinqon added 3 commits June 17, 2024 09:59
@qinqon
e2e: Add scripts to handler ovn-k cluster
7d860d5 
Signed-off-by: Enrique Llorente <[email protected]>
@qinqon
e2e: Add PersistentIPs tests
04c0715 
Signed-off-by: Enrique Llorente <[email protected]>
@qinqon
gh: Add e2e job
92e14a4 
Signed-off-by: Enrique Llorente <[email protected]>
@qinqon qinqon requested review from oshoval and maiqueb June 17, 2024 08:04
oshoval
oshoval approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@oshoval oshoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@maiqueb maiqueb merged commit e2a81fc into kubevirt:main Jun 17, 2024
2 checks passed
oshoval

This comment was marked as off-topic.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oshoval oshoval oshoval requested changes

@maiqueb maiqueb Awaiting requested review from maiqueb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qinqon @oshoval @maiqueb