Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer repo ownership #31

Closed
wants to merge 2 commits into from
Closed

Transfer repo ownership #31

wants to merge 2 commits into from

Conversation

maiqueb
Copy link
Collaborator

@maiqueb maiqueb commented Jun 25, 2024

What this PR does / why we need it:
This PR adjusts the code to build / generate images on the new repo location, since the project was recently renamed and moved to the KubeVirt organization.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
A follow up PR must still account for the deployment manifest updates-

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

NONE

@kubevirt-bot kubevirt-bot added the dco-signoff: no Indicates the PR's author has not DCO signed all their commits. label Jun 25, 2024
Signed-off-by: Miguel Duarte Barroso <[email protected]>
@maiqueb maiqueb force-pushed the transfer-repo-ownership branch from 67725dc to 4980a53 Compare June 25, 2024 15:24
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jun 25, 2024
@oshoval
Copy link
Collaborator

oshoval commented Jun 26, 2024

Hi thanks

We also need changes from this one aren't we #28 ? (was created yesterday)
(will adapt it to the changes you did here)

@@ -29,7 +29,7 @@ jobs:
- name: Ensure latest install manifest
run: |
echo "" > dist/install.yaml
IMG=ghcr.io/maiqueb/kubevirt-ipam-claims:latest make build-installer
IMG=ghcr.io/kubevirt/ipam-controller:latest make build-installer
Copy link
Collaborator

@oshoval oshoval Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldnt it be as this repo name ? kubevirt/ipam-extensions
i do understand it is according the controller name, just wonder if it is fine that it is different
also the publish manifest use the repo name iiuc
https://github.com/kubevirt/ipam-extensions/pull/28/files#diff-b7ac418a59622d832059f2e255c23ec25a8ff3bf10471923e299a80602ed3640L62

i wonder if it has even permissions to push into such URL that is different than ${{ github.repository }}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuing with this as discussed with Quique

@oshoval
Copy link
Collaborator

oshoval commented Jun 26, 2024

Ain't it better the repo name will be as the controller name

https://github.com/kubevirt/kubevirt-ipam-controller ?

@oshoval
Copy link
Collaborator

oshoval commented Jun 26, 2024

Cherry-picked the changes here on #28
which does more required changes in the same topic.

@oshoval
Copy link
Collaborator

oshoval commented Jun 27, 2024

#28 was merged, and includes this PR changes + some more
Thanks

@kubevirt-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 8, 2024
@maiqueb maiqueb closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants