Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-existent package msbuild in latest ubuntu images #82

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

ashokpariya0
Copy link
Contributor

…ntu images.

What this PR does / why we need it:
Build actions, including free disk space, are broken on ubuntu-latest, which now points to Ubuntu 24.04. To resolve this, we have removed the non-existent package from ubuntu-latest.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
We are making these changes to align with the updates in OVN-Kubernetes, as seen in PR #4920.

Release note:

None

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Dec 17, 2024
@ashokpariya0
Copy link
Contributor Author

cc @oshoval

Copy link
Collaborator

@oshoval oshoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2024
@maiqueb
Copy link
Collaborator

maiqueb commented Dec 17, 2024

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maiqueb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2024
@kubevirt-bot kubevirt-bot merged commit 1f29497 into kubevirt:main Dec 17, 2024
4 checks passed
@oshoval
Copy link
Collaborator

oshoval commented Dec 17, 2024

please consider doing same on CNAO if you can
thanks a lot

@ashokpariya0
Copy link
Contributor Author

please consider doing same on CNAO if you can thanks a lot

Sure, it's on my to-do list. I'll get to it soon.

@ashokpariya0
Copy link
Contributor Author

please consider doing same on CNAO if you can thanks a lot

Done, PR: kubevirt/cluster-network-addons-operator#1955

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants