Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown linter for runbooks #234

Merged
merged 4 commits into from
Apr 29, 2024

Conversation

machadovilaca
Copy link
Member

@machadovilaca machadovilaca commented Apr 18, 2024

What this PR does / why we need it:

Adds markdown linter for runbooks with same rules and openshift/runbooks

jira-ticket: https://issues.redhat.com/browse/CNV-40900

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

NONE

Signed-off-by: machadovilaca <[email protected]>
Signed-off-by: machadovilaca <[email protected]>
Signed-off-by: machadovilaca <[email protected]>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Apr 18, 2024
@kubevirt-bot kubevirt-bot requested a review from apinnick April 18, 2024 14:04
Signed-off-by: machadovilaca <[email protected]>
@assafad
Copy link
Collaborator

assafad commented Apr 18, 2024

Very nice, thanks @machadovilaca!
/lgtm

We need to make sure those changes are applied in openshift/runbooks before enabling the runbooks sync tool, and after this PR is merged, or else this tool will open dozens of PRs.

@machadovilaca machadovilaca merged commit 83a950d into kubevirt:main Apr 29, 2024
2 checks passed
@machadovilaca machadovilaca deleted the add-markdown-linter branch April 29, 2024 09:29
github-actions bot pushed a commit that referenced this pull request Apr 29, 2024
…own-linter

Add markdown linter for runbooks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants