Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update runbooks based on downstream wording #240

Conversation

machadovilaca
Copy link
Member

What this PR does / why we need it:

There is some wording on downstream runbooks that we can move to the upstream runbooks to make them more similar

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

Update runbooks wording

@machadovilaca machadovilaca requested a review from sradco May 2, 2024 11:40
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label May 2, 2024
@kubevirt-bot kubevirt-bot requested a review from apinnick May 2, 2024 11:40
@machadovilaca
Copy link
Member Author

/cc @ousleyp

@kubevirt-bot
Copy link

@machadovilaca: GitHub didn't allow me to request PR reviews from the following users: ousleyp.

Note that only kubevirt members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @ousleyp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

@ousleyp ousleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly LGTM, but there are a couple of minor issues (one of them repeats in several files). Thanks!

docs/runbooks/CDINoDefaultStorageClass.md Outdated Show resolved Hide resolved
docs/runbooks/CDINoDefaultStorageClass.md Outdated Show resolved Hide resolved
docs/runbooks/HCOInstallationIncomplete.md Show resolved Hide resolved
docs/runbooks/VirtApiRESTErrorsBurst.md Outdated Show resolved Hide resolved
docs/runbooks/VirtControllerRESTErrorsBurst.md Outdated Show resolved Hide resolved
docs/runbooks/VirtHandlerRESTErrorsBurst.md Outdated Show resolved Hide resolved
docs/runbooks/VirtOperatorRESTErrorsBurst.md Outdated Show resolved Hide resolved
@machadovilaca machadovilaca force-pushed the update-runbooks-based-on-downstream-wording branch from 3818476 to cbc6fbb Compare May 5, 2024 22:55
@machadovilaca machadovilaca force-pushed the update-runbooks-based-on-downstream-wording branch from cbc6fbb to 14c79a6 Compare May 13, 2024 10:46
@machadovilaca machadovilaca force-pushed the update-runbooks-based-on-downstream-wording branch from 14c79a6 to 5d23935 Compare May 15, 2024 10:52
@ousleyp
Copy link
Collaborator

ousleyp commented May 15, 2024

/lgtm

1 similar comment
@sradco
Copy link
Collaborator

sradco commented May 15, 2024

/lgtm

@sradco sradco merged commit a7f1cb6 into kubevirt:main May 15, 2024
2 checks passed
github-actions bot pushed a commit that referenced this pull request May 15, 2024
…nbooks-based-on-downstream-wording

Update runbooks based on downstream wording
@machadovilaca machadovilaca deleted the update-runbooks-based-on-downstream-wording branch May 15, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants