-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update runbooks based on downstream wording #240
Update runbooks based on downstream wording #240
Conversation
/cc @ousleyp |
@machadovilaca: GitHub didn't allow me to request PR reviews from the following users: ousleyp. Note that only kubevirt members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mostly LGTM, but there are a couple of minor issues (one of them repeats in several files). Thanks!
3818476
to
cbc6fbb
Compare
cbc6fbb
to
14c79a6
Compare
Signed-off-by: machadovilaca <[email protected]>
14c79a6
to
5d23935
Compare
/lgtm |
1 similar comment
/lgtm |
…nbooks-based-on-downstream-wording Update runbooks based on downstream wording
What this PR does / why we need it:
There is some wording on downstream runbooks that we can move to the upstream runbooks to make them more similar
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: