Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new repo to track KubeVirt enhancements #3874

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

vladikr
Copy link
Member

@vladikr vladikr commented Jan 7, 2025

What this PR does / why we need it:

Following the recently accepted proposal to create a new repository to track KubeVirt enhancements kubevirt/community#362
This is a PR that aims to request this new repository.

Release note:

NONE

Signed-off-by: Vladik Romanovsky <[email protected]>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jan 7, 2025
@vladikr
Copy link
Member Author

vladikr commented Jan 7, 2025

/cc @dhiller

@kubevirt-bot kubevirt-bot requested a review from dhiller January 7, 2025 04:19
@dhiller
Copy link
Contributor

dhiller commented Jan 7, 2025

/override pull-kubevirt-org-github-config-updater

Job checking the created team is failing because it can't find it - expected behaviour.

@kubevirt-bot
Copy link
Contributor

@dhiller: Overrode contexts on behalf of dhiller: pull-kubevirt-org-github-config-updater

In response to this:

/override pull-kubevirt-org-github-config-updater

Job checking the created team is failing because it can't find it - expected behaviour.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

FYI @brianmcarey

- xpivarc
- vladikr
repos:
enhancements: admin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: in the long run we should cut down on this, since it is not required most of the time. IMHO write access would be enough in general, or do you have something special in mind? Maybe you should consider tide merge automation.

However all that can be done in follow ups, will not block on this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhiller Thank you!
I posted #3876 to fix this.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2025
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2025
@kubevirt-bot kubevirt-bot merged commit 4135112 into kubevirt:main Jan 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants