Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Updates controller-tools version #1222

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

jcanocan
Copy link
Contributor

@jcanocan jcanocan commented Jan 20, 2025

What this PR does / why we need it:

It will help to unlock further updates in SSP. Currently, the controller-gen tool fails with latest external deps updates.

Special notes for your reviewer:

This should unlock dep updates such as #1221

Release note:

None

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 20, 2025
@akrejcir
Copy link
Collaborator

akrejcir commented Jan 20, 2025

Can you please name the PR:

deps: Updates controller-tools version

The chore(deps) is only used by dependabot.

It will help to unlock further updates in SSP. Currently, the
controller-gen tool fails with latest external deps updates.

Signed-off-by: Javier Cano Cano <[email protected]>
@jcanocan jcanocan force-pushed the update-controller-tools branch from b18e3fb to 611e38b Compare January 20, 2025 15:12
@jcanocan jcanocan changed the title chore(deps): Updates controller-tools version deps: Updates controller-tools version Jan 20, 2025
@jcanocan
Copy link
Contributor Author

Can you please name the PR:

deps: Updates controller-tools version

The chore(deps) is only used by dependabot.

Done.

@akrejcir
Copy link
Collaborator

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2025
@ksimon1
Copy link
Member

ksimon1 commented Jan 21, 2025

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ksimon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2025
@kubevirt-bot kubevirt-bot merged commit 24fae45 into kubevirt:main Jan 21, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants