Allow commas in unquoted string + empty map #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From: https://yaml.org/spec/1.2.2/#733-plain-style **inside** flow collections, plain scalars must not contain the “[”, “]”, “{”, “}” and “,” characters. added test cases
gwenzek
force-pushed
the
allow_commas
branch
from
73188a6 to
83d5fdf
Compare
gwenzek
commented
Sep 3, 2024
| else => { | ||
| log.err("Unhandled token in map: {}", .{key}); |
There was a problem hiding this comment.
let me know if you find this is too much
There was a problem hiding this comment.
It's fine but I think if we had some error reporting layer setup it would have been even better.
kubkon
requested changes
Oct 21, 2024
| @@ -6,6 +6,7 @@ const testing = std.testing; | |||
|
|
|||
| buffer: []const u8, | |||
| index: usize = 0, | |||
| in_flow: usize = 0, | |||
There was a problem hiding this comment.
How come it's not enough for in_flow to be a bool?
There was a problem hiding this comment.
this handle nesting of list/mapping. If there are several nested list, I need to remember how many closing tag I need to see before setting "in_flow" to false.
|
Great work! I think there's also a problem when parsing unquoted strings containing colon. For instance, the following currently fails for me: key: a::b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jakub,
thanks for the lib.
I found two minor issues with the libraries:
,is a valid character for unquoted string, except in flowFrom: https://yaml.org/spec/1.2.2/#733-plain-style
inside flow collections, plain scalars must not contain the “[”, “]”, “{”, “}” and “,” characters.
To handle this the tokenizer need to tracks if it's within a flow or not.
{}is a valid map.I can split the PR in two if you prefer, but also the two commits are easy to review independently.