Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kumactl): upgrade grafana/loki to 3.3.2 in observability manifests #12639

Conversation

bartsmykla
Copy link
Contributor

@bartsmykla bartsmykla commented Jan 22, 2025

Motivation

I know we plan to remove kumactl install observability eventually, but I think we should update its components for now, especially if it’s easy to do. Once the versions are more current, Renovate can take care of updates going forward.

Implementation information

Upgraded grafana/loki from 2.5.0 to 3.3.2 in the Kubernetes manifest used by kumactl install observability. Updated loki.yaml to match the new configuration format after following migration steps from 2.6.0 to 3.3.0. Tested locally to ensure everything works as expected.

image

Supporting documentation

Related to: #11693

loki.yaml before (base64 decoded)
auth_enabled: false
chunk_store_config:
  max_look_back_period: 0s
ingester:
  chunk_block_size: 262144
  chunk_idle_period: 3m
  chunk_retain_period: 1m
  lifecycler:
    ring:
      kvstore:
        store: inmemory
      replication_factor: 1
  wal:
    enabled: false
limits_config:
  enforce_metric_name: false
schema_config:
  configs:
  - from: "2018-04-15"
    index:
      period: 168h
      prefix: index_
    object_store: filesystem
    schema: v9
    store: boltdb
server:
  http_listen_port: 3100
storage_config:
  boltdb:
    directory: /data/loki/index
  filesystem:
    directory: /data/loki/chunks
table_manager:
  retention_deletes_enabled: false
  retention_period: 0s
loki.yaml after all migrations (base64 decoded)
auth_enabled: false
querier:
  engine:
    max_look_back_period: 0s
ingester:
  chunk_block_size: 262144
  chunk_idle_period: 3m
  chunk_retain_period: 1m
  lifecycler:
    ring:
      kvstore:
        store: inmemory
      replication_factor: 1
  wal:
    enabled: false
compactor:
  retention_enabled: false
  working_directory: /data/loki/retention
  compaction_interval: 10m
  delete_request_store: tsdb
schema_config:
  configs:
    - from: 2023-10-20
      store: tsdb
      object_store: filesystem
      schema: v13
      index:
        prefix: index_
        period: 24h
storage_config:
  tsdb_shipper:
    active_index_directory: /data/loki/index
    cache_location: /data/loki/cache
  filesystem:
    directory: /data/loki/chunks
table_manager:
  retention_deletes_enabled: false
  retention_period: 0s

Upgraded `grafana/loki` from 2.5.0 to 3.3.2 in the Kubernetes manifest
used by `kumactl install observability`. Updated `loki.yaml` to match
the new configuration format after following migration steps from 2.6.0
to 3.3.0. Tested locally to ensure everything works as expected.

Signed-off-by: Bart Smykla <[email protected]>
@bartsmykla bartsmykla requested review from slonka and lukidzi January 22, 2025 10:57
@bartsmykla bartsmykla requested a review from a team as a code owner January 22, 2025 10:57
slonka
slonka previously approved these changes Jan 22, 2025
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a pretty small change so I'm fine with that but we shouldn't put too much work into this. Just make sure everything works with this version.

Signed-off-by: Bart Smykla <[email protected]>
Copy link
Contributor

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

@bartsmykla bartsmykla merged commit 1418398 into kumahq:master Jan 22, 2025
13 checks passed
@bartsmykla bartsmykla deleted the chore/upgrade-loki-for-kumactl-install-observability branch January 22, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants