Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(github): move test, build and publish to workflow_call #9393

Merged
merged 12 commits into from
Feb 26, 2024
Merged

ci(github): move test, build and publish to workflow_call #9393

merged 12 commits into from
Feb 26, 2024

Conversation

lahabana
Copy link
Contributor

This is another step to do SBOM.
This also makes the build-test-distribute easier to read

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@lahabana lahabana force-pushed the sbom2 branch 5 times, most recently from 1a423f5 to f9f9ef1 Compare February 23, 2024 16:43
@lahabana
ci(github): move test and build to workflow_call
9e6bf16 
This is another step to do SBOM.
This also makes the build-test-distribute easier to read

Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana force-pushed the sbom2 branch 2 times, most recently from 7e0f126 to b562682 Compare February 23, 2024 17:38
@lahabana
fix some secrets
d616da5 
Signed-off-by: Charly Molter <[email protected]>
@lahabana
fix new stuff
36905e3 
Signed-off-by: Charly Molter <[email protected]>
@lahabana
use secrets inherit
810afdd 
Signed-off-by: Charly Molter <[email protected]>
@lahabana
more fixes
5ef27d9 
Signed-off-by: Charly Molter <[email protected]>
@lahabana
fix dumb copilot typos
596443e 
Signed-off-by: Charly Molter <[email protected]>
@lahabana
move publish out
f9217dd 
Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana changed the title ci(github): move test and build to workflow_call ci(github): move test, build and publish to workflow_call Feb 26, 2024
@lahabana
fix publish job
ed5fbf6 
Signed-off-by: Charly Molter <[email protected]>
@lahabana
add make dev/tools
cd77b9d 
Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana marked this pull request as ready for review February 26, 2024 14:56
@lahabana lahabana requested a review from a team as a code owner February 26, 2024 14:56
@lahabana lahabana requested review from slonka, jakubdyszkiewicz and lukidzi and removed request for a team February 26, 2024 14:56
@lahabana lahabana enabled auto-merge (squash) February 26, 2024 16:25
@lahabana lahabana mentioned this pull request Feb 26, 2024
Closed
5 tasks
@lahabana lahabana merged commit 2c1ba74 into kumahq:master Feb 26, 2024
8 of 9 checks passed
@lahabana lahabana deleted the sbom2 branch March 29, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@slonka slonka Awaiting requested review from slonka slonka is a code owner automatically assigned from kumahq/kuma-maintainers

@lukidzi lukidzi Awaiting requested review from lukidzi lukidzi is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lahabana @jakubdyszkiewicz