Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: Add CODEOWNERS #197

Merged
merged 1 commit into from
Dec 31, 2024
Merged

revert: Add CODEOWNERS #197

merged 1 commit into from
Dec 31, 2024

Conversation

kurosakishigure
Copy link
Owner

Description

  • What is the purpose of this PR?
  • What problem does it solve?
    • The submission record is missing
  • Are there any breaking changes or backwards compatibility issues?

Related Issue

Type of Change

  • Reverts commit

How Has This Been Tested?

  • I have run unit tests
  • I have tested the changes manually
  • I have tested in a staging environment

Checklist

  • I have read and followed the guidelines in CONTRIBUTING.md
  • I have already updated the related templates accordingly (if applicable)
  • I have written or updated relevant documentation (if applicable)
  • I have added or updated tests to cover my changes (if applicable)
  • I have reviewed my code for any potential issues

Additional Notes

@kurosakishigure
revert: Add CODEOWNERS
3a8b095 
This reverts commit daf9902.
@github-actions github-actions bot added the revert Reverts commit(PR) label Dec 31, 2024
@kurosakishigure kurosakishigure merged commit 4636a93 into canary Dec 31, 2024
24 checks passed
@kurosakishigure kurosakishigure deleted the revert/191 branch December 31, 2024 20:11
@kurosakishigure
Copy link
Owner Author

kurosakishigure commented Dec 31, 2024 •
edited
Loading

This was a misunderstanding. The root cause was that my local canary branch was outdated, which resulted in the published tag also being outdated.

Future version iterations should be managed through Makefile or GitHub Actions to ensure that similar issues don’t happen again.

@kurosakishigure kurosakishigure mentioned this pull request Dec 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
revert Reverts commit(PR)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kurosakishigure