Skip to content

Commit

Permalink
add comment explaining why docker/tilt-releaser image is used
Browse files Browse the repository at this point in the history
  • Loading branch information
tedim52 committed Dec 11, 2023
1 parent 7727ebf commit 42b72b6
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -467,6 +467,8 @@ jobs:
- "<< pipeline.parameters.engine-server-image-filename >>"

build_cli:
# we use this docker/tilt-releaser image for cli jobs because starlark-lsp requires it to build
# as opposed to running image off cimg/go:<< pipeline.parameters.go-version like every other job
docker:
- image: "docker/tilt-releaser@sha256:ff4a71c0d18717cc9c646778cc426a0a4f916885c5fe7eb001f0eaee0d3483a0"
resource_class: large
Expand Down Expand Up @@ -1177,6 +1179,8 @@ jobs:
scripts/docker-image-builder.sh "${push_to_dockerhub}" "${dockerfile_filepath}" "${image_name_with_version}" "${image_name_to_publish_semver}" "${image_name_to_publish_latest}"
push_cli_artifacts:
# we use this docker/tilt-releaser image for cli jobs because starlark-lsp requires it to build
# as opposed to running image off cimg/go:<< pipeline.parameters.go-version like every other job
docker:
- image: "docker/tilt-releaser@sha256:ff4a71c0d18717cc9c646778cc426a0a4f916885c5fe7eb001f0eaee0d3483a0"
steps:
Expand Down

0 comments on commit 42b72b6

Please sign in to comment.