feat: enable building images in docker [image building pt. 1] #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedim52
force-pushed
the
tedi/build-image
branch
from
e74634f to
68c0787
Compare
tedim52
force-pushed
the
tedi/build-image
branch
from
68c0787 to
6eafea1
Compare
tedim52
force-pushed
the
tedi/build-image
branch
from
6eafea1 to
3de6307
Compare
|
@laurentluce builds are failing in CI, but everything builds locally rn bc I'm using a package that relies on |
|
@tedim52 What does this PR cover in https://www.notion.so/kurtosistech/Image-Building-ITERATION-0-9f1d680dc2b1411699841b65bd8e8794? |
tedim52
changed the title
laurentluce
approved these changes
Dec 7, 2023
tedim52
force-pushed
the
tedi/build-image
branch
from
144802e to
73ec4b0
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 11, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.43](0.85.42...0.85.43) (2023-12-11) ### Features * Add new ports view to the EM UI ([#1919](#1919)) ([027d74b](027d74b)) * add REST API bindings for TS and Golang ([#1907](#1907)) ([97b9b80](97b9b80)) * add support for public ports ([#1905](#1905)) ([97a3d95](97a3d95)) * enable building images in docker [image building pt. 1] ([#1911](#1911)) ([c153873](c153873)) * Reverse proxy lifecycle management and connectivity on Docker ([#1906](#1906)) ([69c5b27](69c5b27)) * service logs full download ([#1895](#1895)) ([b91333f](b91333f)) * Unified REST API ([c3911f6](c3911f6)) ### Bug Fixes * add installation description for oapi-codegen ([#1917](#1917)) ([8f2427b](8f2427b)) * Fix doc checker CI ([#1912](#1912)) ([cc2696d](cc2696d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is pt. 1 of the image building work. Specifically, this PR enables building images in
container-engine-libby addingBuildImageto theKurtosisBackendand implements it inDockerKurtosisBackend.Is this change user facing?
NO