chore: emui sharable components refactor #1923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adschwartz
approved these changes
Dec 13, 2023
Dartoxian
force-pushed
the
bgazzard/catalog-changes
branch
from
26ae653 to
b4b404f
Compare
h4ck3rk3y
pushed a commit
that referenced
this pull request
Dec 15, 2023
## Description: This PR refactors some code out of the emui `components` directory (mostly enclave related) and tweaks code in the `components` directory to remove any dependencies on `KurtosisClient` (EM) and emui app code. This change prepares the `components` directory to be refactored into a shared components libary. The directory does still contain references to the package indexer (which is fine for the catalog.kurtosis.com application), which will need to be refactored later. ## Is this change user facing? NO - no functionality is changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR refactors some code out of the emui
componentsdirectory (mostly enclave related) and tweaks code in thecomponentsdirectory to remove any dependencies onKurtosisClient(EM) and emui app code.This change prepares the
componentsdirectory to be refactored into a shared components libary. The directory does still contain references to the package indexer (which is fine for the catalog.kurtosis.com application), which will need to be refactored later.Is this change user facing?
NO - no functionality is changed