Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

対象プロジェクトのビルド機能を追加.現時点では差分ビルドはできていない. #1 #21

Merged
merged 3 commits into from
May 8, 2018

Conversation

YoshikiHigo
Copy link
Member

レビューお願いします.

@YoshikiHigo YoshikiHigo requested a review from shinsuke-mat May 7, 2018 07:42
@shinsuke-mat
Copy link
Member

pathSeparator

pathSeparatorはこう書いたほうがcool

x static private final String CLASSPATH_SEPARATOR = System.getProperty("os.name").toLowerCase().contains("windows") ? ";" : ":";
o static private final String CLASSPATH_SEPARATOR = File.pathSeparator;

パッケージ

パッケージ構造は後者のほうが自然だと思います.

x jp.kusumotolab.genprog.ProjectBuilder
o jp.kusumotolab.genprog.project.ProjectBuilder

単体テスト

テスト足したほうがよいですね.
Variantありビルドはともかく,初期ソースコードのビルド成否は確認すべき.
#19 を再利用したい & 極力gitシンプルに使いたいので,こういう流れどうでしょう.

  1. このissueはひとまず閉じてmasterにmerge
  2. 題材プロジェクトの追加 #19 をmasterにmerge
  3. 新規issue「ProjectBuilderのテスト追加」を足して新規branchから進める

yoshi added 2 commits May 8, 2018 15:07
add-buidingfunctionality

Conflicts:
	src/main/java/jp/kusumotolab/kgenprog/project/GeneratedAST.java
	src/main/java/jp/kusumotolab/kgenprog/project/GeneratedSourceCode.java
	src/main/java/jp/kusumotolab/kgenprog/project/TargetProject.java
	src/main/java/jp/kusumotolab/kgenprog/project/jdt/GeneratedJDTAST.java
@shinsuke-mat shinsuke-mat merged commit c7270c3 into master May 8, 2018
@shinsuke-mat shinsuke-mat deleted the add-buidingfunctionality branch May 8, 2018 07:02
shinsuke-mat added a commit that referenced this pull request Jul 25, 2018
対象プロジェクトのビルド機能を追加.現時点では差分ビルドはできていない. #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants