Skip to content

Commit

Permalink
fix clang tidy; skip force checkpoint test for in mem mode
Browse files Browse the repository at this point in the history
  • Loading branch information
ray6080 committed Aug 7, 2024
1 parent a10600c commit 217cade
Show file tree
Hide file tree
Showing 13 changed files with 7 additions and 13 deletions.
7 changes: 0 additions & 7 deletions src/include/main/database.h
Original file line number Diff line number Diff line change
Expand Up @@ -101,13 +101,6 @@ class Database {
*/
KUZU_API ~Database();

/**
* @brief Sets the logging level of the database instance.
* @param loggingLevel New logging level. (Supported logging levels are: "info", "debug",
* "err").
*/
KUZU_API static void setLoggingLevel(std::string loggingLevel);

// TODO(Ziyi): Instead of exposing a dedicated API for adding a new function, we should consider
// add function through the extension module.
void addTableFunction(std::string name,
Expand Down
1 change: 1 addition & 0 deletions src/include/storage/buffer_manager/bm_file_handle.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#include <atomic>
#include <cmath>
#include <cstdint>
#include <functional>

#include "common/concurrent_vector.h"
#include "common/constants.h"
Expand Down
2 changes: 1 addition & 1 deletion src/include/storage/storage_structure/overflow_file.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@
#include <fcntl.h>

#include <cstdint>
#include <functional>
#include <memory>
#include <string_view>
#include <vector>

#include "common/constants.h"
#include "common/types/types.h"
#include "storage/buffer_manager/bm_file_handle.h"
#include "storage/buffer_manager/buffer_manager.h"
#include "storage/file_handle.h"
#include "storage/index/hash_index_utils.h"
#include "storage/storage_structure/in_mem_page.h"
Expand Down
1 change: 0 additions & 1 deletion src/include/storage/wal/wal.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

#include "common/enums/rel_direction.h"
#include "common/serializer/buffered_file.h"
#include "storage/buffer_manager/buffer_manager.h"
#include "storage/wal/wal_record.h"

namespace kuzu {
Expand Down
1 change: 1 addition & 0 deletions src/main/database.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#include "main/database.h"

#include "main/database_manager.h"
#include "storage/buffer_manager/buffer_manager.h"

#if defined(_WIN32)
#include <windows.h>
Expand Down
1 change: 1 addition & 0 deletions src/storage/index/hash_index.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
#include "common/types/ku_string.h"
#include "common/types/types.h"
#include "storage/buffer_manager/bm_file_handle.h"
#include "storage/buffer_manager/buffer_manager.h"
#include "storage/file_handle.h"
#include "storage/index/hash_index_header.h"
#include "storage/index/hash_index_slot.h"
Expand Down
1 change: 1 addition & 0 deletions src/storage/storage_manager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
#include "common/file_system/virtual_file_system.h"
#include "main/client_context.h"
#include "main/database.h"
#include "storage/buffer_manager/buffer_manager.h"
#include "storage/buffer_manager/memory_manager.h"
#include "storage/store/node_table.h"
#include "storage/store/rel_table.h"
Expand Down
1 change: 0 additions & 1 deletion src/storage/storage_structure/db_file_utils.cpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#include "storage/storage_structure/db_file_utils.h"

#include "storage/buffer_manager/bm_file_handle.h"
#include "storage/buffer_manager/buffer_manager.h"
#include "storage/wal/shadow_file.h"
#include "transaction/transaction.h"

Expand Down
1 change: 0 additions & 1 deletion src/storage/storage_structure/disk_array_collection.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
#include "common/constants.h"
#include "common/types/types.h"
#include "storage/buffer_manager/bm_file_handle.h"
#include "storage/buffer_manager/buffer_manager.h"
#include "storage/storage_structure/db_file_utils.h"

using namespace kuzu::common;
Expand Down
1 change: 1 addition & 0 deletions src/storage/storage_structure/overflow_file.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
#include "common/type_utils.h"
#include "common/types/types.h"
#include "storage/buffer_manager/bm_file_handle.h"
#include "storage/buffer_manager/buffer_manager.h"
#include "storage/file_handle.h"
#include "storage/storage_structure/db_file_utils.h"
#include "storage/storage_structure/in_mem_page.h"
Expand Down
1 change: 0 additions & 1 deletion src/storage/store/column_chunk_data.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
#include "common/vector/value_vector.h"
#include "expression_evaluator/expression_evaluator.h"
#include "storage/buffer_manager/bm_file_handle.h"
#include "storage/buffer_manager/buffer_manager.h"
#include "storage/compression/compression.h"
#include "storage/store/list_chunk_data.h"
#include "storage/store/string_chunk_data.h"
Expand Down
1 change: 0 additions & 1 deletion src/storage/store/dictionary_column.cpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#include "storage/store/dictionary_column.h"

#include "storage/storage_structure/disk_array_collection.h"
#include "storage/store/string_chunk_data.h"
#include "storage/store/string_column.h"
#include <bit>

Expand Down
1 change: 1 addition & 0 deletions test/test_files/transaction/basic.test
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ Timeout waiting for active transactions to leave the system before checkpointing
---- 0

-CASE ForceCheckpointWhenClosingDB
-SKIP_IN_MEM
-STATEMENT CALL auto_checkpoint=false
---- ok
-STATEMENT CREATE NODE TABLE person(ID INT64, age INT64, PRIMARY KEY(ID));
Expand Down

0 comments on commit 217cade

Please sign in to comment.