Fix ci and udt

kuzudb · Jul 25, 2024 · dd840d8 · dd840d8
1 parent 2311215
commit dd840d8
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 3 deletions.
diff --git a/src/binder/bind/bind_ddl.cpp b/src/binder/bind/bind_ddl.cpp
@@ -201,7 +201,11 @@ std::unique_ptr<BoundStatement> Binder::bindCreateTable(const Statement& stateme
 std::unique_ptr<BoundStatement> Binder::bindCreateType(const Statement& statement) {
     auto createType = statement.constPtrCast<CreateType>();
     auto name = createType->getName();
-    auto type = LogicalType::fromString(createType->getDataType());
+    LogicalType type;
+    if (!LogicalType::tryConvertFromString(createType->getDataType(), type)) {
+        type =
+            clientContext->getCatalog()->getType(clientContext->getTx(), createType->getDataType());
+    }
     if (clientContext->getCatalog()->containsType(clientContext->getTx(), name)) {
         throw BinderException{common::stringFormat("Duplicated type name: {}.", name)};
     }

diff --git a/src/include/binder/ddl/bound_create_table_info.h b/src/include/binder/ddl/bound_create_table_info.h
@@ -90,8 +90,6 @@ struct KUZU_API BoundExtraCreateTableInfo : public BoundExtraCreateCatalogEntryI
         : BoundExtraCreateTableInfo{copyVector(other.propertyInfos)} {}
     BoundExtraCreateTableInfo& operator=(const BoundExtraCreateTableInfo&) = delete;
 
-    BoundExtraCreateTableInfo& operator=(const BoundExtraCreateTableInfo&) = delete;
-
     std::unique_ptr<BoundExtraCreateCatalogEntryInfo> copy() const override {
         return std::make_unique<BoundExtraCreateTableInfo>(*this);
     }

diff --git a/test/test_files/user_defined_types/user_defined_types.test b/test/test_files/user_defined_types/user_defined_types.test
@@ -92,3 +92,21 @@ Binder exception: Duplicated type name: DESCRIPTION.
 30|40|False|
 5|20|False|
 8|100|False|
+
+-CASE Example
+-STATEMENT CREATE TYPE BIGINT AS INT64;
+---- ok
+-STATEMENT CREATE NODE TABLE PERSON (ID BIGINT, PRIMARY KEY(ID));
+---- ok
+-STATEMENT CREATE (p:PERSON {ID: 5});
+---- ok
+-STATEMENT CREATE (p:PERSON {ID: 10});
+---- ok
+-STATEMENT MATCH (p:PERSON) RETURN CAST(p.ID AS INT32);
+---- 2
+5
+10
+-STATEMENT CREATE TYPE LENGTH AS BIGINT;
+---- ok
+-STATEMENT CREATE NODE TABLE STUDENT (ID BIGINT, HEIGHT LENGTH, PRIMARY KEY(ID));
+---- ok