Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option force_checkpoint_on_close #4032

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Add option force_checkpoint_on_close #4032

merged 3 commits into from
Aug 6, 2024

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Aug 5, 2024

Description

Add an option to force checkpoint upon database closing.

@ray6080 ray6080 changed the title Add option force_checkpoint_on_close Add option force_checkpoint_on_close Aug 5, 2024
Copy link

github-actions bot commented Aug 5, 2024

Benchmark Result

Master commit hash: b88aca112024631118b667bbe41441a542347475
Branch commit hash: 7e20287012b6a35f0ff45a5258cd9773888bc72a

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 683.64 684.84 -1.20 (-0.17%)
aggregation q28 11776.83 12119.40 -342.57 (-2.83%)
filter q14 159.06 160.90 -1.84 (-1.14%)
filter q15 161.13 159.48 1.65 (1.03%)
filter q16 333.60 334.71 -1.11 (-0.33%)
filter q17 483.11 481.08 2.03 (0.42%)
filter q18 1941.59 1960.56 -18.96 (-0.97%)
fixed_size_expr_evaluator q07 570.84 571.87 -1.03 (-0.18%)
fixed_size_expr_evaluator q08 786.42 786.68 -0.26 (-0.03%)
fixed_size_expr_evaluator q09 784.26 785.94 -1.68 (-0.21%)
fixed_size_expr_evaluator q10 272.80 273.14 -0.34 (-0.12%)
fixed_size_expr_evaluator q11 267.42 267.41 0.00 (0.00%)
fixed_size_expr_evaluator q12 267.82 266.59 1.24 (0.46%)
fixed_size_expr_evaluator q13 1511.56 1504.77 6.79 (0.45%)
fixed_size_seq_scan q23 148.67 150.88 -2.21 (-1.46%)
join q31 39.61 52.73 -13.12 (-24.89%)
ldbc_snb_ic q35 3499.03 3690.90 -191.88 (-5.20%)
ldbc_snb_ic q36 133.04 130.27 2.77 (2.13%)
ldbc_snb_is q32 10.62 9.66 0.96 (9.98%)
ldbc_snb_is q33 97.40 97.21 0.19 (0.19%)
ldbc_snb_is q34 95.20 79.92 15.28 (19.12%)
multi-rel multi-rel-large-scan 3121.55 2777.88 343.67 (12.37%)
multi-rel multi-rel-lookup 79.49 80.21 -0.72 (-0.90%)
multi-rel multi-rel-small-scan 56.90 62.56 -5.67 (-9.06%)
order_by q25 165.26 164.96 0.30 (0.18%)
order_by q26 490.76 499.50 -8.75 (-1.75%)
order_by q27 1424.92 1432.58 -7.66 (-0.53%)
scan_after_filter q01 206.04 207.78 -1.75 (-0.84%)
scan_after_filter q02 195.45 196.56 -1.11 (-0.56%)
shortest_path_ldbc100 q39 117.56 93.81 23.75 (25.32%)
var_size_expr_evaluator q03 2087.45 2097.71 -10.26 (-0.49%)
var_size_expr_evaluator q04 2277.03 2317.44 -40.41 (-1.74%)
var_size_expr_evaluator q05 2560.38 2575.45 -15.07 (-0.59%)
var_size_expr_evaluator q06 1368.87 1367.18 1.70 (0.12%)
var_size_seq_scan q19 1506.46 1498.41 8.05 (0.54%)
var_size_seq_scan q20 3145.68 3216.88 -71.19 (-2.21%)
var_size_seq_scan q21 2423.14 2528.56 -105.42 (-4.17%)
var_size_seq_scan q22 136.95 138.40 -1.45 (-1.05%)

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.15%. Comparing base (b88aca1) to head (5044802).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4032      +/-   ##
==========================================
- Coverage   85.15%   85.15%   -0.01%     
==========================================
  Files        1297     1297              
  Lines       50514    50523       +9     
  Branches     6955     6954       -1     
==========================================
+ Hits        43016    43023       +7     
- Misses       7368     7370       +2     
  Partials      130      130              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 6, 2024

Benchmark Result

Master commit hash: b88aca112024631118b667bbe41441a542347475
Branch commit hash: 81d4bc5d036912afa081a0333faca9f63c23b1e3

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 700.48 684.84 15.64 (2.28%)
aggregation q28 11784.50 12119.40 -334.90 (-2.76%)
copy node-Comment 68124.44 N/A N/A
copy node-Forum 5297.91 N/A N/A
copy node-Organisation 1465.49 N/A N/A
copy node-Person 2621.15 N/A N/A
copy node-Place 1457.37 N/A N/A
copy node-Post 25972.66 N/A N/A
copy node-Tag 1497.65 N/A N/A
copy node-Tagclass 704.84 N/A N/A
copy rel-comment-hasCreator 57018.43 N/A N/A
copy rel-comment-hasTag 76241.49 N/A N/A
copy rel-comment-isLocatedIn 63222.50 N/A N/A
copy rel-containerOf 18047.85 N/A N/A
copy rel-forum-hasTag 3885.13 N/A N/A
copy rel-hasInterest 2680.57 N/A N/A
copy rel-hasMember 52145.40 N/A N/A
copy rel-hasModerator 1780.92 N/A N/A
copy rel-hasType 624.17 N/A N/A
copy rel-isPartOf 634.92 N/A N/A
copy rel-isSubclassOf 611.53 N/A N/A
copy rel-knows 5818.60 N/A N/A
copy rel-likes-comment 90860.30 N/A N/A
copy rel-likes-post 32119.55 N/A N/A
copy rel-organisation-isLocatedIn 732.49 N/A N/A
copy rel-person-isLocatedIn 735.20 N/A N/A
copy rel-post-hasCreator 16077.13 N/A N/A
copy rel-post-hasTag 22696.14 N/A N/A
copy rel-post-isLocatedIn 17273.17 N/A N/A
copy rel-replyOf-comment 64339.77 N/A N/A
copy rel-replyOf-post 44682.75 N/A N/A
copy rel-studyAt 908.26 N/A N/A
copy rel-workAt 1004.61 N/A N/A
filter q14 159.59 160.90 -1.31 (-0.82%)
filter q15 157.40 159.48 -2.08 (-1.30%)
filter q16 334.01 334.71 -0.70 (-0.21%)
filter q17 479.77 481.08 -1.31 (-0.27%)
filter q18 1951.99 1960.56 -8.57 (-0.44%)
fixed_size_expr_evaluator q07 578.71 571.87 6.85 (1.20%)
fixed_size_expr_evaluator q08 797.80 786.68 11.12 (1.41%)
fixed_size_expr_evaluator q09 799.25 785.94 13.31 (1.69%)
fixed_size_expr_evaluator q10 273.21 273.14 0.07 (0.03%)
fixed_size_expr_evaluator q11 268.38 267.41 0.96 (0.36%)
fixed_size_expr_evaluator q12 265.70 266.59 -0.88 (-0.33%)
fixed_size_expr_evaluator q13 1509.88 1504.77 5.11 (0.34%)
fixed_size_seq_scan q23 155.41 150.88 4.53 (3.00%)
join q31 50.31 52.73 -2.43 (-4.60%)
ldbc_snb_ic q35 3765.24 3690.90 74.34 (2.01%)
ldbc_snb_ic q36 131.79 130.27 1.52 (1.17%)
ldbc_snb_is q32 10.66 9.66 1.00 (10.34%)
ldbc_snb_is q33 96.92 97.21 -0.29 (-0.30%)
ldbc_snb_is q34 95.99 79.92 16.07 (20.10%)
multi-rel multi-rel-large-scan 3492.77 2777.88 714.89 (25.74%)
multi-rel multi-rel-lookup 67.30 80.21 -12.91 (-16.09%)
multi-rel multi-rel-small-scan 71.46 62.56 8.89 (14.22%)
order_by q25 163.78 164.96 -1.18 (-0.71%)
order_by q26 494.87 499.50 -4.64 (-0.93%)
order_by q27 1446.64 1432.58 14.06 (0.98%)
scan_after_filter q01 208.03 207.78 0.25 (0.12%)
scan_after_filter q02 195.46 196.56 -1.10 (-0.56%)
shortest_path_ldbc100 q39 77.79 93.81 -16.02 (-17.07%)
var_size_expr_evaluator q03 2091.95 2097.71 -5.77 (-0.27%)
var_size_expr_evaluator q04 2303.01 2317.44 -14.43 (-0.62%)
var_size_expr_evaluator q05 2575.34 2575.45 -0.11 (-0.00%)
var_size_expr_evaluator q06 1360.03 1367.18 -7.15 (-0.52%)
var_size_seq_scan q19 1493.68 1498.41 -4.73 (-0.32%)
var_size_seq_scan q20 3163.89 3216.88 -52.98 (-1.65%)
var_size_seq_scan q21 2415.49 2528.56 -113.07 (-4.47%)
var_size_seq_scan q22 137.11 138.40 -1.29 (-0.93%)

@andyfengHKU andyfengHKU merged commit 7feb44e into master Aug 6, 2024
32 checks passed
@andyfengHKU andyfengHKU deleted the force-checkpoint branch August 6, 2024 21:55
ray6080 added a commit that referenced this pull request Aug 14, 2024
* add option force_checkpoint_on_close

* update test and extension version

* bump extension version
ted-wq-x pushed a commit to ted-wq-x/kuzu that referenced this pull request Nov 14, 2024
* add option force_checkpoint_on_close

* update test and extension version

* bump extension version

(cherry picked from commit 7feb44e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants