Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor list auxiliary buffer #4052

Merged
merged 2 commits into from
Aug 11, 2024
Merged

Conversation

andyfengHKU
Copy link
Contributor

@andyfengHKU andyfengHKU commented Aug 9, 2024

Description

This PR solves a bug when we try to refer a list child vector from another list child vector. The bug was because we only set the vector itself but did not copy the corresponding auxiliary buffer metadata, e.g. size & capacity. This PR fixes the bug and also refactor related APIs.

Fixes # (issue)

Contributor agreement

Copy link

github-actions bot commented Aug 9, 2024

Benchmark Result

Master commit hash: 2f1cdf6a33511b893c988ae7028ad74277268397
Branch commit hash: e5ba84d6c1ff3c61dc4f4e198759574001ab3457

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 677.44 685.66 -8.22 (-1.20%)
aggregation q28 11579.85 12172.11 -592.26 (-4.87%)
filter q14 151.84 158.50 -6.65 (-4.20%)
filter q15 151.39 160.82 -9.43 (-5.86%)
filter q16 334.91 332.17 2.74 (0.82%)
filter q17 473.08 480.64 -7.56 (-1.57%)
filter q18 1987.07 1943.35 43.72 (2.25%)
fixed_size_expr_evaluator q07 565.57 577.13 -11.56 (-2.00%)
fixed_size_expr_evaluator q08 776.88 788.98 -12.11 (-1.53%)
fixed_size_expr_evaluator q09 776.56 784.64 -8.08 (-1.03%)
fixed_size_expr_evaluator q10 266.49 281.22 -14.73 (-5.24%)
fixed_size_expr_evaluator q11 260.25 274.39 -14.14 (-5.15%)
fixed_size_expr_evaluator q12 258.04 274.56 -16.52 (-6.02%)
fixed_size_expr_evaluator q13 1492.40 1499.75 -7.35 (-0.49%)
fixed_size_seq_scan q23 144.02 152.17 -8.14 (-5.35%)
join q31 12.57 12.79 -0.22 (-1.72%)
ldbc_snb_ic q35 740.88 752.81 -11.93 (-1.58%)
ldbc_snb_ic q36 47.76 50.34 -2.58 (-5.13%)
ldbc_snb_is q32 9.23 10.68 -1.45 (-13.57%)
ldbc_snb_is q33 19.61 19.70 -0.09 (-0.46%)
ldbc_snb_is q34 8.75 8.88 -0.12 (-1.39%)
multi-rel multi-rel-large-scan 2833.13 2847.88 -14.75 (-0.52%)
multi-rel multi-rel-lookup 58.54 81.08 -22.54 (-27.80%)
multi-rel multi-rel-small-scan 54.51 65.52 -11.01 (-16.80%)
order_by q25 155.91 161.02 -5.11 (-3.17%)
order_by q26 482.29 486.29 -4.00 (-0.82%)
order_by q27 1465.63 1428.97 36.65 (2.56%)
scan_after_filter q01 197.51 206.26 -8.76 (-4.25%)
scan_after_filter q02 187.67 195.15 -7.47 (-3.83%)
shortest_path_ldbc100 q39 157.58 156.39 1.19 (0.76%)
var_size_expr_evaluator q03 2113.69 2077.44 36.25 (1.75%)
var_size_expr_evaluator q04 2262.14 2272.56 -10.42 (-0.46%)
var_size_expr_evaluator q05 2657.19 2682.86 -25.67 (-0.96%)
var_size_expr_evaluator q06 1351.26 1343.03 8.24 (0.61%)
var_size_seq_scan q19 1497.08 1486.25 10.83 (0.73%)
var_size_seq_scan q20 3155.74 3156.57 -0.82 (-0.03%)
var_size_seq_scan q21 2394.34 2421.23 -26.88 (-1.11%)
var_size_seq_scan q22 135.78 134.35 1.42 (1.06%)

src/include/common/vector/value_vector.h Outdated Show resolved Hide resolved
src/include/common/vector/value_vector.h Outdated Show resolved Hide resolved
src/include/common/vector/value_vector.h Outdated Show resolved Hide resolved
src/include/common/vector/value_vector.h Show resolved Hide resolved
@andyfengHKU andyfengHKU force-pushed the refactor-list-auxiliary-buffer branch from af0dddd to f309c19 Compare August 10, 2024 22:03
@andyfengHKU andyfengHKU force-pushed the refactor-list-auxiliary-buffer branch from 3e36152 to dbc4547 Compare August 10, 2024 22:37
Copy link

Benchmark Result

Master commit hash: f08f80d08b3164d36f3e593e058afe3b58e4c17b
Branch commit hash: 6519b113a8ff57fb05f9e54f792ce5170bf3c085

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 675.27 685.00 -9.72 (-1.42%)
aggregation q28 11645.27 11728.70 -83.44 (-0.71%)
filter q14 151.34 160.46 -9.12 (-5.68%)
filter q15 152.78 157.94 -5.16 (-3.27%)
filter q16 323.98 342.67 -18.68 (-5.45%)
filter q17 473.80 479.94 -6.13 (-1.28%)
filter q18 1937.20 1950.95 -13.75 (-0.70%)
fixed_size_expr_evaluator q07 567.63 572.21 -4.58 (-0.80%)
fixed_size_expr_evaluator q08 782.22 790.71 -8.49 (-1.07%)
fixed_size_expr_evaluator q09 785.54 779.88 5.66 (0.73%)
fixed_size_expr_evaluator q10 267.63 272.57 -4.95 (-1.82%)
fixed_size_expr_evaluator q11 262.48 267.46 -4.98 (-1.86%)
fixed_size_expr_evaluator q12 261.22 265.38 -4.16 (-1.57%)
fixed_size_expr_evaluator q13 1484.54 1510.47 -25.94 (-1.72%)
fixed_size_seq_scan q23 144.84 150.40 -5.56 (-3.70%)
join q31 12.79 12.59 0.20 (1.60%)
ldbc_snb_ic q35 774.08 773.12 0.96 (0.12%)
ldbc_snb_ic q36 38.09 51.10 -13.00 (-25.44%)
ldbc_snb_is q32 8.87 9.44 -0.57 (-6.04%)
ldbc_snb_is q33 19.24 17.31 1.94 (11.19%)
ldbc_snb_is q34 8.56 8.95 -0.39 (-4.40%)
multi-rel multi-rel-large-scan 2878.06 2874.51 3.54 (0.12%)
multi-rel multi-rel-lookup 64.44 60.86 3.57 (5.87%)
multi-rel multi-rel-small-scan 58.29 56.92 1.37 (2.40%)
order_by q25 154.43 165.08 -10.65 (-6.45%)
order_by q26 477.78 478.98 -1.20 (-0.25%)
order_by q27 1431.75 1437.19 -5.43 (-0.38%)
scan_after_filter q01 198.60 206.41 -7.81 (-3.79%)
scan_after_filter q02 186.91 195.41 -8.50 (-4.35%)
shortest_path_ldbc100 q39 158.60 158.50 0.10 (0.06%)
var_size_expr_evaluator q03 2079.57 2085.78 -6.21 (-0.30%)
var_size_expr_evaluator q04 2252.85 2273.79 -20.93 (-0.92%)
var_size_expr_evaluator q05 2683.78 2660.59 23.19 (0.87%)
var_size_expr_evaluator q06 1333.82 1362.80 -28.98 (-2.13%)
var_size_seq_scan q19 1478.44 1496.79 -18.35 (-1.23%)
var_size_seq_scan q20 3140.07 3191.11 -51.05 (-1.60%)
var_size_seq_scan q21 2403.81 2423.04 -19.23 (-0.79%)
var_size_seq_scan q22 135.66 135.94 -0.28 (-0.20%)

@andyfengHKU andyfengHKU merged commit 771ab8a into master Aug 11, 2024
@andyfengHKU andyfengHKU deleted the refactor-list-auxiliary-buffer branch August 11, 2024 02:50
ray6080 pushed a commit that referenced this pull request Aug 14, 2024
* Refactor list auxilary buffer

* Run clang-format

---------

Co-authored-by: CI Bot <[email protected]>
ted-wq-x pushed a commit to ted-wq-x/kuzu that referenced this pull request Nov 14, 2024
* Refactor list auxilary buffer

* Run clang-format

---------

Co-authored-by: CI Bot <[email protected]>
(cherry picked from commit 771ab8a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants