Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed cli default mode to multiline #4253

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Changed cli default mode to multiline #4253

merged 2 commits into from
Sep 13, 2024

Conversation

MSebanc
Copy link
Collaborator

@MSebanc MSebanc commented Sep 13, 2024

Description

Made multiline mode the default mode of the shell. Tests for different editing features now run both multiline and singleline versions of the test.

Contributor agreement

@MSebanc MSebanc requested a review from andyfengHKU September 13, 2024 01:19
Copy link
Contributor

@andyfengHKU andyfengHKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

Benchmark Result

Master commit hash: 37e35665dd940cdbe2dd2c1f6be758a17fbe6c9c
Branch commit hash: dd7e7dd0547c33b93b6e15730759635d5b79999e

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 668.07 665.11 2.96 (0.44%)
aggregation q28 11863.65 11857.51 6.13 (0.05%)
filter q14 147.54 148.80 -1.25 (-0.84%)
filter q15 150.37 148.56 1.81 (1.22%)
filter q16 337.68 340.34 -2.65 (-0.78%)
filter q17 469.17 471.85 -2.68 (-0.57%)
filter q18 1938.33 1926.23 12.09 (0.63%)
fixed_size_expr_evaluator q07 562.07 555.10 6.97 (1.26%)
fixed_size_expr_evaluator q08 778.93 779.11 -0.18 (-0.02%)
fixed_size_expr_evaluator q09 772.75 776.50 -3.74 (-0.48%)
fixed_size_expr_evaluator q10 263.04 256.26 6.79 (2.65%)
fixed_size_expr_evaluator q11 256.40 251.09 5.31 (2.11%)
fixed_size_expr_evaluator q12 257.72 250.70 7.02 (2.80%)
fixed_size_expr_evaluator q13 1501.43 1499.38 2.05 (0.14%)
fixed_size_seq_scan q23 133.87 135.78 -1.91 (-1.41%)
join q31 12.01 11.77 0.24 (2.02%)
ldbc_snb_ic q35 805.01 807.38 -2.37 (-0.29%)
ldbc_snb_ic q36 41.05 46.60 -5.55 (-11.90%)
ldbc_snb_is q32 9.34 8.52 0.82 (9.59%)
ldbc_snb_is q33 17.49 16.15 1.33 (8.26%)
ldbc_snb_is q34 7.22 7.91 -0.69 (-8.74%)
multi-rel multi-rel-large-scan 2901.14 3276.66 -375.52 (-11.46%)
multi-rel multi-rel-lookup 69.74 56.86 12.87 (22.64%)
multi-rel multi-rel-small-scan 69.15 53.66 15.50 (28.88%)
order_by q25 149.59 146.24 3.34 (2.29%)
order_by q26 468.32 467.98 0.34 (0.07%)
order_by q27 1436.90 1440.53 -3.63 (-0.25%)
scan_after_filter q01 194.27 191.13 3.14 (1.64%)
scan_after_filter q02 182.62 180.09 2.53 (1.41%)
shortest_path_ldbc100 q37 3502.84 3496.11 6.73 (0.19%)
shortest_path_ldbc100 q39 52.94 52.70 0.24 (0.46%)
shortest_path_ldbc100 q40 66.80 65.77 1.03 (1.56%)
var_size_expr_evaluator q03 2124.78 2121.24 3.54 (0.17%)
var_size_expr_evaluator q04 2250.96 2248.53 2.42 (0.11%)
var_size_expr_evaluator q05 2569.14 2567.30 1.84 (0.07%)
var_size_expr_evaluator q06 1413.07 1417.79 -4.73 (-0.33%)
var_size_seq_scan q19 1497.33 1501.28 -3.95 (-0.26%)
var_size_seq_scan q20 3300.45 3293.55 6.91 (0.21%)
var_size_seq_scan q21 2523.82 2506.41 17.40 (0.69%)
var_size_seq_scan q22 134.56 134.05 0.51 (0.38%)

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.74%. Comparing base (28512ca) to head (8edf40e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4253   +/-   ##
=======================================
  Coverage   86.74%   86.74%           
=======================================
  Files        1327     1327           
  Lines       51588    51588           
  Branches     6950     6951    +1     
=======================================
+ Hits        44750    44751    +1     
+ Misses       6666     6665    -1     
  Partials      172      172           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark Result

Master commit hash: 9ed82ac0346558f4ef1b1ca4dcfc86846b9a5c06
Branch commit hash: 7a10ca1a9ba2efa2cd553b4997c38ed7cca03a53

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 658.24 677.91 -19.67 (-2.90%)
aggregation q28 15094.72 11169.58 3925.15 (35.14%)
filter q14 135.50 158.29 -22.79 (-14.40%)
filter q15 141.48 158.71 -17.23 (-10.86%)
filter q16 309.01 333.79 -24.78 (-7.42%)
filter q17 457.27 480.15 -22.89 (-4.77%)
filter q18 1920.22 1922.99 -2.77 (-0.14%)
fixed_size_expr_evaluator q07 547.02 575.87 -28.84 (-5.01%)
fixed_size_expr_evaluator q08 761.18 786.11 -24.93 (-3.17%)
fixed_size_expr_evaluator q09 765.41 787.21 -21.81 (-2.77%)
fixed_size_expr_evaluator q10 249.78 276.52 -26.74 (-9.67%)
fixed_size_expr_evaluator q11 245.26 270.02 -24.77 (-9.17%)
fixed_size_expr_evaluator q12 243.43 269.72 -26.30 (-9.75%)
fixed_size_expr_evaluator q13 1472.64 1503.86 -31.22 (-2.08%)
fixed_size_seq_scan q23 135.86 147.65 -11.80 (-7.99%)
join q31 11.45 11.87 -0.42 (-3.55%)
ldbc_snb_ic q35 820.16 751.15 69.01 (9.19%)
ldbc_snb_ic q36 47.86 48.03 -0.17 (-0.35%)
ldbc_snb_is q32 9.13 8.25 0.88 (10.70%)
ldbc_snb_is q33 16.61 19.03 -2.41 (-12.69%)
ldbc_snb_is q34 5.91 8.66 -2.75 (-31.74%)
multi-rel multi-rel-large-scan 2992.18 2709.73 282.45 (10.42%)
multi-rel multi-rel-lookup 75.36 40.62 34.73 (85.51%)
multi-rel multi-rel-small-scan 52.36 58.45 -6.09 (-10.41%)
order_by q25 140.58 166.42 -25.84 (-15.53%)
order_by q26 456.84 494.66 -37.82 (-7.65%)
order_by q27 1414.27 1447.51 -33.24 (-2.30%)
scan_after_filter q01 181.13 205.72 -24.58 (-11.95%)
scan_after_filter q02 171.63 193.31 -21.69 (-11.22%)
shortest_path_ldbc100 q37 3463.34 3516.56 -53.23 (-1.51%)
shortest_path_ldbc100 q39 59.25 87.76 -28.51 (-32.49%)
shortest_path_ldbc100 q40 77.70 89.05 -11.34 (-12.74%)
var_size_expr_evaluator q03 2064.07 2107.12 -43.05 (-2.04%)
var_size_expr_evaluator q04 2230.48 2254.91 -24.43 (-1.08%)
var_size_expr_evaluator q05 2692.83 2578.01 114.83 (4.45%)
var_size_expr_evaluator q06 1380.26 1426.70 -46.44 (-3.26%)
var_size_seq_scan q19 1479.37 1514.17 -34.80 (-2.30%)
var_size_seq_scan q20 3157.51 3179.63 -22.12 (-0.70%)
var_size_seq_scan q21 2439.17 2480.06 -40.89 (-1.65%)
var_size_seq_scan q22 131.55 137.08 -5.53 (-4.04%)

@MSebanc MSebanc merged commit fb0ee9e into master Sep 13, 2024
25 checks passed
@MSebanc MSebanc deleted the cli-multiline-default branch September 13, 2024 15:52
ted-wq-x pushed a commit to ted-wq-x/kuzu that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants