Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fts bug fix #4677

Merged
merged 2 commits into from
Jan 4, 2025
Merged

Fts bug fix #4677

merged 2 commits into from
Jan 4, 2025

Conversation

acquamarin
Copy link
Collaborator

Fix query_fts use incorrect stemmer bug.
Add more tests.

@acquamarin acquamarin changed the title Fts fix Fts bug fix Jan 4, 2025
@acquamarin acquamarin requested a review from andyfengHKU January 4, 2025 01:38
Copy link

github-actions bot commented Jan 4, 2025

Benchmark Result

Master commit hash: 34397ed5b886a3956acf0fe3d5f52a488138c905
Branch commit hash: a32042ae02c70ec6ae2fd238e05df3ef18efc892

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 655.57 652.98 2.59 (0.40%)
aggregation q28 11783.87 11465.14 318.73 (2.78%)
filter q14 135.11 137.34 -2.23 (-1.62%)
filter q15 140.81 134.44 6.37 (4.74%)
filter q16 315.11 320.88 -5.77 (-1.80%)
filter q17 457.86 455.75 2.11 (0.46%)
filter q18 1963.52 1947.46 16.06 (0.82%)
filter zonemap-node 98.65 100.16 -1.52 (-1.51%)
filter zonemap-node-lhs-cast 99.02 97.83 1.20 (1.22%)
filter zonemap-node-null 94.97 93.92 1.05 (1.12%)
filter zonemap-rel 5825.96 6042.12 -216.16 (-3.58%)
fixed_size_expr_evaluator q07 592.29 584.42 7.87 (1.35%)
fixed_size_expr_evaluator q08 810.64 827.27 -16.62 (-2.01%)
fixed_size_expr_evaluator q09 812.22 812.68 -0.47 (-0.06%)
fixed_size_expr_evaluator q10 247.13 249.51 -2.38 (-0.95%)
fixed_size_expr_evaluator q11 239.70 238.29 1.41 (0.59%)
fixed_size_expr_evaluator q12 239.52 235.37 4.15 (1.76%)
fixed_size_expr_evaluator q13 1461.99 1495.22 -33.23 (-2.22%)
fixed_size_seq_scan q23 120.10 126.06 -5.97 (-4.73%)
join q29 600.53 621.43 -20.89 (-3.36%)
join q30 10047.83 10923.50 -875.67 (-8.02%)
join q31 6.93 6.33 0.60 (9.45%)
join SelectiveTwoHopJoin 52.41 52.12 0.29 (0.55%)
ldbc_snb_ic q35 2595.06 2503.42 91.64 (3.66%)
ldbc_snb_ic q36 443.94 475.67 -31.73 (-6.67%)
ldbc_snb_is q32 7.20 5.94 1.26 (21.12%)
ldbc_snb_is q33 13.69 14.07 -0.38 (-2.69%)
ldbc_snb_is q34 1.31 1.31 0.00 (0.00%)
multi-rel multi-rel-large-scan 1375.60 1334.43 41.16 (3.08%)
multi-rel multi-rel-lookup 6.35 17.63 -11.28 (-63.99%)
multi-rel multi-rel-small-scan 100.20 102.13 -1.93 (-1.89%)
order_by q25 145.47 136.40 9.07 (6.65%)
order_by q26 460.65 465.63 -4.98 (-1.07%)
order_by q27 1487.43 1473.19 14.24 (0.97%)
recursive_join recursive-join-bidirection 310.25 301.69 8.57 (2.84%)
recursive_join recursive-join-dense 7471.71 6014.45 1457.26 (24.23%)
recursive_join recursive-join-path 24201.85 24116.55 85.30 (0.35%)
recursive_join recursive-join-sparse 1061.66 1070.24 -8.58 (-0.80%)
recursive_join recursive-join-trail 7365.61 6642.83 722.77 (10.88%)
scan_after_filter q01 182.09 179.28 2.81 (1.57%)
scan_after_filter q02 167.23 166.52 0.70 (0.42%)
shortest_path_ldbc100 q37 95.34 87.06 8.28 (9.51%)
shortest_path_ldbc100 q38 362.42 371.29 -8.87 (-2.39%)
shortest_path_ldbc100 q39 62.80 66.26 -3.46 (-5.22%)
shortest_path_ldbc100 q40 435.34 446.14 -10.79 (-2.42%)
var_size_expr_evaluator q03 2086.18 2085.76 0.42 (0.02%)
var_size_expr_evaluator q04 2264.67 2303.44 -38.77 (-1.68%)
var_size_expr_evaluator q05 2744.92 2742.16 2.76 (0.10%)
var_size_expr_evaluator q06 1368.80 1350.06 18.74 (1.39%)
var_size_seq_scan q19 1478.00 1463.75 14.25 (0.97%)
var_size_seq_scan q20 2683.67 2703.31 -19.63 (-0.73%)
var_size_seq_scan q21 2279.69 2292.29 -12.60 (-0.55%)
var_size_seq_scan q22 128.07 128.30 -0.23 (-0.18%)

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.13%. Comparing base (5ec9fee) to head (d0e2ccb).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4677      +/-   ##
==========================================
- Coverage   86.39%   86.13%   -0.27%     
==========================================
  Files        1373     1373              
  Lines       58293    58303      +10     
  Branches     7210     7210              
==========================================
- Hits        50365    50220     -145     
- Misses       7764     7919     +155     
  Partials      164      164              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acquamarin acquamarin merged commit 7c64c15 into master Jan 4, 2025
24 of 25 checks passed
@acquamarin acquamarin deleted the fts-fix branch January 4, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants