-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index entry serialization #4686
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4686 +/- ##
==========================================
- Coverage 86.22% 86.17% -0.06%
==========================================
Files 1369 1371 +2
Lines 58232 58270 +38
Branches 7206 7206
==========================================
+ Hits 50213 50214 +1
- Misses 7855 7892 +37
Partials 164 164 ☔ View full report in Codecov by Sentry. |
0731b7b
to
7feb3cd
Compare
Benchmark ResultMaster commit hash:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also put a high level description of how the serialize/deSerialize of index entries work for extensions?
Otherwise looks good to me. See some comments below.
Benchmark ResultMaster commit hash:
|
This PR supports serializing index catalog entries to disk.
General idea:
Serialization:
We serialize the full index entries to disk.
Deserialization:
We only deserialize the base class and save the auxiliary information in an array.
When the extension is loaded, it is going to deserialize the auxiliary information stored in the array and recreate the index.