Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output irrelevant docs in FTS #4694

Closed
wants to merge 1 commit into from
Closed

output irrelevant docs in FTS #4694

wants to merge 1 commit into from

Conversation

acquamarin
Copy link
Collaborator

This PR changes the output of FTS to output irrelevant docs(docs with null score) as well.
This makes our fts output consistent with duckdb.

Copy link

github-actions bot commented Jan 9, 2025

Benchmark Result

Master commit hash: d5acb796e384d3de68e7be15f6ba5c0ef6bcdc64
Branch commit hash: ef08f3dcef539be472c267e96c411f4756eea34a

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 653.36 655.32 -1.96 (-0.30%)
aggregation q28 11468.65 11494.18 -25.53 (-0.22%)
filter q14 135.47 138.10 -2.63 (-1.90%)
filter q15 136.65 139.28 -2.63 (-1.89%)
filter q16 311.45 317.88 -6.43 (-2.02%)
filter q17 453.65 454.64 -0.99 (-0.22%)
filter q18 1969.85 1954.54 15.31 (0.78%)
filter zonemap-node 97.42 99.50 -2.08 (-2.09%)
filter zonemap-node-lhs-cast 96.81 97.78 -0.96 (-0.99%)
filter zonemap-node-null 92.87 94.18 -1.31 (-1.40%)
filter zonemap-rel 5675.56 5740.84 -65.29 (-1.14%)
fixed_size_expr_evaluator q07 590.81 564.24 26.57 (4.71%)
fixed_size_expr_evaluator q08 831.79 810.79 21.00 (2.59%)
fixed_size_expr_evaluator q09 826.15 809.95 16.20 (2.00%)
fixed_size_expr_evaluator q10 249.41 244.92 4.49 (1.83%)
fixed_size_expr_evaluator q11 241.64 239.03 2.61 (1.09%)
fixed_size_expr_evaluator q12 239.30 234.93 4.37 (1.86%)
fixed_size_expr_evaluator q13 1497.83 1469.46 28.37 (1.93%)
fixed_size_seq_scan q23 121.00 116.99 4.02 (3.43%)
join q29 607.69 599.57 8.11 (1.35%)
join q30 9857.85 11008.46 -1150.61 (-10.45%)
join q31 4.43 5.94 -1.51 (-25.44%)
join SelectiveTwoHopJoin 53.27 55.58 -2.31 (-4.16%)
ldbc_snb_ic q35 2609.27 2676.02 -66.74 (-2.49%)
ldbc_snb_ic q36 468.57 473.46 -4.89 (-1.03%)
ldbc_snb_is q32 5.75 5.63 0.12 (2.07%)
ldbc_snb_is q33 11.91 13.35 -1.45 (-10.82%)
ldbc_snb_is q34 1.19 1.20 -0.01 (-1.03%)
multi-rel multi-rel-large-scan 1340.42 1300.67 39.75 (3.06%)
multi-rel multi-rel-lookup 33.66 34.51 -0.85 (-2.46%)
multi-rel multi-rel-small-scan 74.69 83.97 -9.28 (-11.05%)
order_by q25 137.99 144.88 -6.89 (-4.76%)
order_by q26 475.21 482.19 -6.98 (-1.45%)
order_by q27 1462.76 1492.70 -29.94 (-2.01%)
recursive_join recursive-join-bidirection 273.59 283.60 -10.01 (-3.53%)
recursive_join recursive-join-dense 7310.21 5441.75 1868.46 (34.34%)
recursive_join recursive-join-path 23779.59 23804.62 -25.03 (-0.11%)
recursive_join recursive-join-sparse 1059.15 1064.18 -5.04 (-0.47%)
recursive_join recursive-join-trail 7294.29 6066.14 1228.15 (20.25%)
scan_after_filter q01 177.32 178.64 -1.31 (-0.73%)
scan_after_filter q02 164.41 164.87 -0.45 (-0.27%)
shortest_path_ldbc100 q37 90.22 101.96 -11.75 (-11.52%)
shortest_path_ldbc100 q38 325.83 339.09 -13.26 (-3.91%)
shortest_path_ldbc100 q39 65.55 66.28 -0.73 (-1.10%)
shortest_path_ldbc100 q40 449.34 355.23 94.11 (26.49%)
var_size_expr_evaluator q03 2071.83 2056.20 15.63 (0.76%)
var_size_expr_evaluator q04 2249.99 2237.42 12.57 (0.56%)
var_size_expr_evaluator q05 2635.51 2626.86 8.66 (0.33%)
var_size_expr_evaluator q06 1341.27 1354.91 -13.65 (-1.01%)
var_size_seq_scan q19 1450.83 1468.18 -17.36 (-1.18%)
var_size_seq_scan q20 2622.06 2604.30 17.76 (0.68%)
var_size_seq_scan q21 2276.09 2309.84 -33.74 (-1.46%)
var_size_seq_scan q22 128.57 132.66 -4.09 (-3.08%)

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.17%. Comparing base (d5acb79) to head (000e95c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4694   +/-   ##
=======================================
  Coverage   86.17%   86.17%           
=======================================
  Files        1375     1375           
  Lines       58491    58491           
  Branches     7221     7220    -1     
=======================================
  Hits        50407    50407           
  Misses       7920     7920           
  Partials      164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acquamarin acquamarin closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant