Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checkpoint configuration parameters to the API bindings #4739

Merged
merged 8 commits into from
Jan 21, 2025
Merged

Add checkpoint configuration parameters to the API bindings #4739

merged 8 commits into from
Jan 21, 2025

Conversation

royi-luo
Copy link
Collaborator

Description

Add auto_checkpoint and checkpoint_threshold configurations to the API bindings.

Fixes #4575

Contributor agreement

@royi-luo royi-luo self-assigned this Jan 17, 2025
@github-actions GitHub Actions
Copy link

Benchmark Result

Master commit hash: d0e34cb08ff22c1293485056e4d9b723061de779
Branch commit hash: ec01cbd07af76f6caa5d973b15919f289e416964

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 649.60 693.72 -44.12 (-6.36%)
aggregation q28 10904.11 11657.52 -753.41 (-6.46%)
filter q14 135.77 135.89 -0.12 (-0.09%)
filter q15 138.32 143.29 -4.98 (-3.47%)
filter q16 323.56 314.73 8.83 (2.80%)
filter q17 453.52 462.12 -8.60 (-1.86%)
filter q18 1970.89 1995.77 -24.88 (-1.25%)
filter zonemap-node 97.35 98.52 -1.18 (-1.19%)
filter zonemap-node-lhs-cast 96.89 99.50 -2.61 (-2.62%)
filter zonemap-node-null 93.07 95.76 -2.69 (-2.80%)
filter zonemap-rel 5861.09 5853.72 7.37 (0.13%)
fixed_size_expr_evaluator q07 584.54 584.53 0.00 (0.00%)
fixed_size_expr_evaluator q08 812.64 812.10 0.54 (0.07%)
fixed_size_expr_evaluator q09 810.21 811.63 -1.42 (-0.17%)
fixed_size_expr_evaluator q10 246.83 249.40 -2.57 (-1.03%)
fixed_size_expr_evaluator q11 239.76 238.17 1.59 (0.67%)
fixed_size_expr_evaluator q12 234.98 235.02 -0.04 (-0.02%)
fixed_size_expr_evaluator q13 1465.17 1469.57 -4.40 (-0.30%)
fixed_size_seq_scan q23 117.51 122.14 -4.62 (-3.79%)
join q29 637.94 599.01 38.93 (6.50%)
join q30 10277.60 9951.13 326.47 (3.28%)
join q31 5.60 5.83 -0.23 (-3.94%)
join SelectiveTwoHopJoin 58.87 53.59 5.28 (9.85%)
ldbc_snb_ic q35 2621.34 2639.50 -18.16 (-0.69%)
ldbc_snb_ic q36 467.93 453.53 14.40 (3.18%)
ldbc_snb_is q32 6.46 6.09 0.38 (6.19%)
ldbc_snb_is q33 15.48 11.37 4.11 (36.12%)
ldbc_snb_is q34 1.24 1.32 -0.08 (-6.05%)
multi-rel multi-rel-large-scan 1527.38 1520.13 7.24 (0.48%)
multi-rel multi-rel-lookup 83.57 57.88 25.69 (44.40%)
multi-rel multi-rel-small-scan 1379.71 1430.10 -50.39 (-3.52%)
order_by q25 142.43 146.19 -3.76 (-2.57%)
order_by q26 455.52 463.23 -7.71 (-1.66%)
order_by q27 1492.62 1515.25 -22.63 (-1.49%)
recursive_join recursive-join-bidirection 294.43 292.80 1.63 (0.56%)
recursive_join recursive-join-dense 7370.60 7380.29 -9.69 (-0.13%)
recursive_join recursive-join-path 23787.37 23801.90 -14.53 (-0.06%)
recursive_join recursive-join-sparse 1050.99 1058.85 -7.86 (-0.74%)
recursive_join recursive-join-trail 7311.65 7306.33 5.32 (0.07%)
scan_after_filter q01 180.29 187.40 -7.10 (-3.79%)
scan_after_filter q02 164.97 168.10 -3.13 (-1.86%)
shortest_path_ldbc100 q37 99.16 80.90 18.26 (22.57%)
shortest_path_ldbc100 q38 300.25 376.38 -76.13 (-20.23%)
shortest_path_ldbc100 q39 64.41 60.71 3.70 (6.09%)
shortest_path_ldbc100 q40 267.12 468.19 -201.07 (-42.95%)
var_size_expr_evaluator q03 2109.40 2096.31 13.09 (0.62%)
var_size_expr_evaluator q04 2253.76 2255.63 -1.87 (-0.08%)
var_size_expr_evaluator q05 2571.03 2571.77 -0.75 (-0.03%)
var_size_expr_evaluator q06 1357.40 1375.00 -17.60 (-1.28%)
var_size_seq_scan q19 1478.81 1486.47 -7.66 (-0.52%)
var_size_seq_scan q20 2797.16 2773.53 23.63 (0.85%)
var_size_seq_scan q21 2292.68 2294.01 -1.32 (-0.06%)
var_size_seq_scan q22 130.88 130.58 0.30 (0.23%)

@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.29%. Comparing base (04ec81f) to head (d1eed98).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4739      +/-   ##
==========================================
- Coverage   86.29%   86.29%   -0.01%     
==========================================
  Files        1396     1396              
  Lines       59873    59848      -25     
  Branches     7358     7370      +12     
==========================================
- Hits        51669    51647      -22     
+ Misses       8037     8034       -3     
  Partials      167      167

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@royi-luo royi-luo force-pushed the royi/add-checkpoint-config-to-apis branch from a2f0f2a to 7e48229 Compare January 20, 2025 14:26
@github-actions GitHub Actions
Copy link

Benchmark Result

Master commit hash: bb6d3ec271ffb8e3ca8f7c59f3a873eae2385d77
Branch commit hash: 5846cd3c499a9282021122e45d6b07fa16c16869

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 634.20 648.55 -14.35 (-2.21%)
aggregation q28 11353.84 12080.39 -726.55 (-6.01%)
copy node-Comment 70394.86 N/A N/A
copy node-Forum 5464.87 N/A N/A
copy node-Organisation 1236.88 N/A N/A
copy node-Person 2071.13 N/A N/A
copy node-Place 1164.24 N/A N/A
copy node-Post 29498.40 N/A N/A
copy node-Tag 1253.35 N/A N/A
copy node-Tagclass 1169.32 N/A N/A
copy rel-comment-hasCreator 54156.23 N/A N/A
copy rel-comment-hasTag 89123.53 N/A N/A
copy rel-comment-isLocatedIn 67646.20 N/A N/A
copy rel-containerOf 14423.56 N/A N/A
copy rel-forum-hasTag 4046.02 N/A N/A
copy rel-hasInterest 3067.85 N/A N/A
copy rel-hasMember 117617.01 N/A N/A
copy rel-hasModerator 1325.33 N/A N/A
copy rel-hasType 247.10 N/A N/A
copy rel-isPartOf 250.66 N/A N/A
copy rel-isSubclassOf 245.23 N/A N/A
copy rel-knows 13440.67 N/A N/A
copy rel-likes-comment 174769.54 N/A N/A
copy rel-likes-post 69077.59 N/A N/A
copy rel-organisation-isLocatedIn 284.20 N/A N/A
copy rel-person-isLocatedIn 462.21 N/A N/A
copy rel-post-hasCreator 14361.34 N/A N/A
copy rel-post-hasTag 23080.99 N/A N/A
copy rel-post-isLocatedIn 17783.42 N/A N/A
copy rel-replyOf-comment 48123.67 N/A N/A
copy rel-replyOf-post 36557.79 N/A N/A
copy rel-studyAt 829.89 N/A N/A
copy rel-workAt 1636.04 N/A N/A
filter q14 118.39 137.75 -19.35 (-14.05%)
filter q15 116.50 135.63 -19.13 (-14.11%)
filter q16 296.01 317.25 -21.24 (-6.69%)
filter q17 438.20 461.54 -23.34 (-5.06%)
filter q18 1911.94 1976.29 -64.35 (-3.26%)
filter zonemap-node 80.92 99.26 -18.33 (-18.47%)
filter zonemap-node-lhs-cast 82.62 100.23 -17.61 (-17.57%)
filter zonemap-node-null 77.69 96.17 -18.47 (-19.21%)
filter zonemap-rel 5709.10 5826.81 -117.71 (-2.02%)
fixed_size_expr_evaluator q07 573.92 580.11 -6.19 (-1.07%)
fixed_size_expr_evaluator q08 800.11 809.10 -8.98 (-1.11%)
fixed_size_expr_evaluator q09 799.38 809.33 -9.95 (-1.23%)
fixed_size_expr_evaluator q10 237.44 245.14 -7.69 (-3.14%)
fixed_size_expr_evaluator q11 228.97 237.50 -8.53 (-3.59%)
fixed_size_expr_evaluator q12 225.43 234.88 -9.45 (-4.02%)
fixed_size_expr_evaluator q13 1443.79 1465.19 -21.40 (-1.46%)
fixed_size_seq_scan q23 108.05 117.53 -9.48 (-8.07%)
join q29 610.46 591.63 18.83 (3.18%)
join q30 10415.26 9880.31 534.95 (5.41%)
join q31 7.00 6.95 0.04 (0.60%)
join SelectiveTwoHopJoin 61.81 58.37 3.43 (5.88%)
ldbc_snb_ic q35 2594.50 2606.92 -12.42 (-0.48%)
ldbc_snb_ic q36 469.14 463.38 5.76 (1.24%)
ldbc_snb_is q32 2.59 6.48 -3.89 (-59.99%)
ldbc_snb_is q33 13.75 15.61 -1.85 (-11.88%)
ldbc_snb_is q34 1.48 1.33 0.15 (11.26%)
multi-rel multi-rel-large-scan 1398.39 1604.33 -205.94 (-12.84%)
multi-rel multi-rel-lookup 9.25 43.77 -34.52 (-78.87%)
multi-rel multi-rel-small-scan 94.45 1449.06 -1354.61 (-93.48%)
order_by q25 119.94 136.69 -16.75 (-12.26%)
order_by q26 444.98 465.68 -20.69 (-4.44%)
order_by q27 1460.36 1479.21 -18.84 (-1.27%)
recursive_join recursive-join-bidirection 291.05 312.94 -21.89 (-7.00%)
recursive_join recursive-join-dense 7417.31 7395.65 21.66 (0.29%)
recursive_join recursive-join-path 24120.06 23451.36 668.70 (2.85%)
recursive_join recursive-join-sparse 1060.09 1066.37 -6.28 (-0.59%)
recursive_join recursive-join-trail 7405.69 7348.22 57.47 (0.78%)
scan_after_filter q01 163.71 178.91 -15.20 (-8.50%)
scan_after_filter q02 148.62 167.34 -18.72 (-11.19%)
shortest_path_ldbc100 q37 84.94 89.08 -4.14 (-4.65%)
shortest_path_ldbc100 q38 360.00 355.57 4.43 (1.25%)
shortest_path_ldbc100 q39 62.73 63.84 -1.11 (-1.74%)
shortest_path_ldbc100 q40 460.29 371.90 88.39 (23.77%)
var_size_expr_evaluator q03 2056.35 2087.31 -30.96 (-1.48%)
var_size_expr_evaluator q04 2227.66 2269.74 -42.08 (-1.85%)
var_size_expr_evaluator q05 2529.12 5299.71 -2770.58 (-52.28%)
var_size_expr_evaluator q06 1319.13 1332.67 -13.54 (-1.02%)
var_size_seq_scan q19 1441.46 1455.58 -14.12 (-0.97%)
var_size_seq_scan q20 2618.52 2669.81 -51.29 (-1.92%)
var_size_seq_scan q21 2263.62 2310.84 -47.22 (-2.04%)
var_size_seq_scan q22 125.65 128.30 -2.65 (-2.06%)

@royi-luo royi-luo force-pushed the royi/add-checkpoint-config-to-apis branch from 050a5c1 to d1eed98 Compare January 20, 2025 19:12
@github-actions GitHub Actions
Copy link

Benchmark Result

Master commit hash: b70eabf68b13f248c788cde379177601b012bb0d
Branch commit hash: 8740ebb09faa3c184fdd9820c556c3d8970e661a

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 633.40 621.57 11.82 (1.90%)
aggregation q28 11009.65 12092.78 -1083.13 (-8.96%)
filter q14 120.39 117.16 3.23 (2.76%)
filter q15 116.26 124.18 -7.92 (-6.38%)
filter q16 299.90 296.40 3.49 (1.18%)
filter q17 437.70 443.24 -5.53 (-1.25%)
filter q18 1907.48 1917.28 -9.80 (-0.51%)
filter zonemap-node 83.52 80.66 2.86 (3.55%)
filter zonemap-node-lhs-cast 81.42 83.68 -2.26 (-2.70%)
filter zonemap-node-null 77.21 80.09 -2.88 (-3.59%)
filter zonemap-rel 5702.32 5729.78 -27.46 (-0.48%)
fixed_size_expr_evaluator q07 569.72 574.77 -5.05 (-0.88%)
fixed_size_expr_evaluator q08 810.39 822.01 -11.62 (-1.41%)
fixed_size_expr_evaluator q09 801.06 801.70 -0.65 (-0.08%)
fixed_size_expr_evaluator q10 235.42 236.43 -1.01 (-0.43%)
fixed_size_expr_evaluator q11 228.23 229.36 -1.13 (-0.49%)
fixed_size_expr_evaluator q12 225.54 226.17 -0.63 (-0.28%)
fixed_size_expr_evaluator q13 1441.36 1467.46 -26.10 (-1.78%)
fixed_size_seq_scan q23 115.08 111.19 3.90 (3.51%)
join q29 607.18 615.74 -8.56 (-1.39%)
join q30 10412.52 10053.85 358.67 (3.57%)
join q31 6.30 5.57 0.73 (13.02%)
join SelectiveTwoHopJoin 55.26 53.70 1.55 (2.89%)
ldbc_snb_ic q35 2570.89 2592.62 -21.73 (-0.84%)
ldbc_snb_ic q36 491.11 477.79 13.32 (2.79%)
ldbc_snb_is q32 4.81 5.47 -0.66 (-12.10%)
ldbc_snb_is q33 15.09 10.81 4.28 (39.58%)
ldbc_snb_is q34 1.51 1.37 0.14 (10.36%)
multi-rel multi-rel-large-scan 1418.17 1408.12 10.06 (0.71%)
multi-rel multi-rel-lookup 31.94 44.04 -12.09 (-27.46%)
multi-rel multi-rel-small-scan 63.39 70.10 -6.71 (-9.57%)
order_by q25 123.25 127.80 -4.54 (-3.56%)
order_by q26 447.43 451.16 -3.73 (-0.83%)
order_by q27 1462.38 1486.94 -24.56 (-1.65%)
recursive_join recursive-join-bidirection 302.81 268.91 33.90 (12.61%)
recursive_join recursive-join-dense 7364.94 7334.43 30.51 (0.42%)
recursive_join recursive-join-path 23724.53 23605.45 119.08 (0.50%)
recursive_join recursive-join-sparse 1061.31 1056.81 4.50 (0.43%)
recursive_join recursive-join-trail 7352.34 7374.37 -22.03 (-0.30%)
scan_after_filter q01 162.51 165.88 -3.37 (-2.03%)
scan_after_filter q02 151.26 151.58 -0.32 (-0.21%)
shortest_path_ldbc100 q37 92.37 92.98 -0.62 (-0.66%)
shortest_path_ldbc100 q38 399.30 344.89 54.41 (15.78%)
shortest_path_ldbc100 q39 62.31 65.57 -3.26 (-4.97%)
shortest_path_ldbc100 q40 447.99 457.16 -9.16 (-2.00%)
var_size_expr_evaluator q03 2064.69 2086.24 -21.55 (-1.03%)
var_size_expr_evaluator q04 2204.35 2226.05 -21.70 (-0.97%)
var_size_expr_evaluator q05 2523.95 2565.74 -41.79 (-1.63%)
var_size_expr_evaluator q06 1317.39 1322.53 -5.14 (-0.39%)
var_size_seq_scan q19 1441.62 1446.67 -5.06 (-0.35%)
var_size_seq_scan q20 2634.69 2639.82 -5.12 (-0.19%)
var_size_seq_scan q21 2263.78 2275.65 -11.87 (-0.52%)
var_size_seq_scan q22 125.44 125.56 -0.12 (-0.09%)

@royi-luo royi-luo marked this pull request as ready for review January 20, 2025 19:55
@royi-luo royi-luo requested a review from mewim January 20, 2025 19:55
mewim
mewim approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@mewim mewim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple change LGTM

@royi-luo royi-luo merged commit 8181476 into master Jan 21, 2025
25 checks passed
@royi-luo royi-luo deleted the royi/add-checkpoint-config-to-apis branch January 21, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mewim mewim mewim approved these changes

@benjaminwinger benjaminwinger Awaiting requested review from benjaminwinger benjaminwinger is a code owner

Assignees

@royi-luo royi-luo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add checkpoint configuration parameters to the API bindings
2 participants
@royi-luo @mewim