Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMake unable to detect OpenMP in Windows runner #117

Merged
merged 7 commits into from
Nov 19, 2024
Merged

Conversation

kyamagu
Copy link
Owner

@kyamagu kyamagu commented Nov 12, 2024

Changes:

  • Fix windows build error due to CMake unable to detect OpenMP

@kyamagu
Copy link
Owner Author

kyamagu commented Nov 14, 2024

The windows build error seems a bug in CMake.
https://stackoverflow.com/a/78342596

@kyamagu
Copy link
Owner Author

kyamagu commented Nov 14, 2024

@kyamagu kyamagu changed the title v1.9.0.post1 release Fix CMake unable to detect OpenMP in Windows runner Nov 18, 2024
@kyamagu kyamagu added the bug Something isn't working label Nov 18, 2024
@kyamagu
Copy link
Owner Author

kyamagu commented Nov 19, 2024

Neither adding an OpenMP_RUNTIME_MSVC var nor downgrading CMake to 3.29 did not solve the error.
As the last commit succeeded https://github.com/kyamagu/faiss-wheels/actions/runs/11606114456, this error is happening due to some change in the windows runner environment.

@kyamagu
Copy link
Owner Author

kyamagu commented Nov 19, 2024

It looks like the conda dependency changed. The last successful build installed the following conda packages:

      package                    |            build
      ---------------------------|-----------------
      ca-certificates-2024.8.30  |       h56e8100_0         155 KB  conda-forge
      certifi-2024.8.30          |     pyhd8ed1ab_0         160 KB  conda-forge
      libflang-5.0.0             |h6538335_20180525         519 KB  conda-forge
      libopenblas-0.3.28         |pthreads_hf0a32cb_0         3.8 MB  conda-forge
      llvm-meta-5.0.0            |                0           3 KB  conda-forge
      openblas-0.3.28            |pthreads_h[291](https://github.com/kyamagu/faiss-wheels/actions/runs/11606114456/job/32317610963#step:7:292)61c6_0         259 KB  conda-forge
      openmp-5.0.0               |           vc14_1         577 KB  conda-forge
      openssl-3.3.2              |       h2466b09_0         8.0 MB  conda-forge
      ucrt-10.0.22621.0          |       h57928b3_1         547 KB  conda-forge
      vc14_runtime-14.40.33810   |      hcc2c482_22         733 KB  conda-forge
      vs2015_runtime-14.40.33810 |      h3bf8584_22          17 KB  conda-forge
      ------------------------------------------------------------

The failing attempts install the following dependency:

      package                    |            build
      ---------------------------|-----------------
      ca-certificates-2024.8.30  |       h56e8100_0         155 KB  conda-forge
      certifi-2024.8.30          |     pyhd8ed1ab_0         160 KB  conda-forge
      libopenblas-0.3.28         |pthreads_head3c61_1         3.8 MB  conda-forge
      openblas-0.3.28            |pthreads_h4a7f399_1         262 KB  conda-forge
      openssl-3.4.0              |       h2466b09_0         8.1 MB  conda-forge
      ucrt-10.0.22621.0          |       h57928b3_1         547 KB  conda-forge
      vc14_runtime-14.40.33810   |      hcc2c482_22         733 KB  conda-forge
      vs2015_runtime-14.40.33810 |      h3bf8584_22          17 KB  conda-forge
      ------------------------------------------------------------
                                             Total:        13.7 MB

For some reason, libflang and openmp removed from the depenency.

@kyamagu kyamagu merged commit 22e7f55 into main Nov 19, 2024
3 of 6 checks passed
@kyamagu kyamagu deleted the v1.9.0.post1 branch November 19, 2024 01:10
@kyamagu kyamagu restored the v1.9.0.post1 branch November 19, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant