Add colormap scaler and offset uniforms #60
Conversation
src/webgl/color/colormap.js
Outdated
|
|
||
| if (!imageColormap) { | ||
| return; | ||
| } | ||
|
|
||
| return { | ||
| u_colormap_texture: imageColormap, | ||
| colormapScaler: typeof colormapScaler != 'undefined' ? colormapScaler : 0.5, |
There was a problem hiding this comment.
Any reason why not to do colormapScaler || 0.5? That's easier to read. Are there instances when colormapScaler is truthy but not set by the user?
There was a problem hiding this comment.
colormapScaler || 0.5 is ok, but colormapOffset || 0.5 not, I just wanted to use the same pattern for both
There was a problem hiding this comment.
You mean because colormapOffset can be 0? Then use
colormapScaler: Number.isFinite(colormapScaler) ? colormapScaler : 0.5
?
That seems easier to follow than typeof colormapScaler != 'undefined' because you're testing what it should be rather than what it shouldn't be. I.e. if colormapScaler were a string, it would pass above but crash the shaders probably?
There was a problem hiding this comment.
Right, makes sense. Updated.
There was a problem hiding this comment.
Alternatively, default values could be changed to scaler = 1, offset = 0, and then || is enough, but that would require changes in examples as well.
Yeah I think this is the core issue to be resolved at some point, but it doesn't have to be right now |
zakjan
force-pushed
the
colormap-scaler-offset
branch
2 times, most recently
from
d628f43 to
57e28ba
Compare
zakjan
force-pushed
the
colormap-scaler-offset
branch
from
57e28ba to
3ee80fd
Compare
Usecase: to be able to use colormap on values [0..1] (scaler = 1, offset = 0; these values might even be default)
linearRescale could be used for this usecase before colormap. However, a module can't be used multiple times in the same shader (#39). In my case (#58), I need either a duplicate linearRescale2 module, or configurable scaler/offset uniforms in colormap.