Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OIDC: allow retrieving kubeconfig from BTP #2124

Merged
merged 6 commits into from
Jun 3, 2024
Merged

OIDC: allow retrieving kubeconfig from BTP #2124

merged 6 commits into from
Jun 3, 2024

Conversation

halamix2
Copy link
Member

@halamix2 halamix2 commented May 31, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • OIDC: allow retrieving kubeconfig from BTP
  • remove separate clusterServer & caCertificate flags to simplify the command by passing whole api.Config inside

Related issue(s)

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 31, 2024
@kyma-bot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 31, 2024
@halamix2 halamix2 marked this pull request as ready for review June 3, 2024 10:07
@halamix2 halamix2 requested a review from a team as a code owner June 3, 2024 10:07
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 3, 2024
@pPrecel pPrecel self-assigned this Jun 3, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 3, 2024
@kyma-bot kyma-bot merged commit 4e2198a into kyma-project:main Jun 3, 2024
3 checks passed
@halamix2 halamix2 deleted the oidc-cis branch June 3, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pPrecel pPrecel pPrecel approved these changes

Assignees

@pPrecel pPrecel

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@halamix2 @kyma-bot @pPrecel