Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional worker node pools docs #1617

Conversation

KsaweryZietara
Copy link
Contributor

Description

Changes proposed in this pull request:

  • create additional worker node pools document,
  • add new properties to 03-10-service-description.md.

Related issue(s)
See also #952

@KsaweryZietara KsaweryZietara added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Jan 10, 2025
@KsaweryZietara KsaweryZietara self-assigned this Jan 10, 2025
@KsaweryZietara KsaweryZietara requested a review from a team as a code owner January 10, 2025 08:00
@kyma-bot kyma-bot added area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. labels Jan 10, 2025
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) January 10, 2025 08:00
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 10, 2025
@KsaweryZietara KsaweryZietara added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2025
IwonaLanger
IwonaLanger previously approved these changes Jan 15, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 15, 2025
docs/user/04-40-additional-worker-node-pools.md Outdated Show resolved Hide resolved
docs/user/04-40-additional-worker-node-pools.md Outdated Show resolved Hide resolved
docs/user/04-40-additional-worker-node-pools.md Outdated Show resolved Hide resolved
docs/user/04-40-additional-worker-node-pools.md Outdated Show resolved Hide resolved
docs/user/04-40-additional-worker-node-pools.md Outdated Show resolved Hide resolved
docs/user/04-40-additional-worker-node-pools.md Outdated Show resolved Hide resolved
docs/user/04-40-additional-worker-node-pools.md Outdated Show resolved Hide resolved
}
```

2. A user sends an update request (HTTP PUT) with the following JSON in the payload:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. A user sends an update request (HTTP PUT) with the following JSON in the payload:
2. A user sends an update request (HTTP PUT) with the following JSON in the payload:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as line 102.

Copy link
Contributor Author

@KsaweryZietara KsaweryZietara Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will replace it with JSON file.

}
```

3. The additional worker node pools are updated to include the values of the `additionalWorkerNodePools` object from JSON provided in the update request:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. The additional worker node pools are updated to include the values of the `additionalWorkerNodePools` object from JSON provided in the update request:
3. The additional worker node pools are updated to include the values of the `additionalWorkerNodePools` object from JSON provided in the update request:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as line 102.

Copy link
Contributor Author

@KsaweryZietara KsaweryZietara Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will replace it with JSON file.

@KsaweryZietara KsaweryZietara removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2025
@kyma-gopher-bot kyma-gopher-bot merged commit cb59d71 into kyma-project:main Jan 15, 2025
6 of 8 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 15, 2025
@KsaweryZietara KsaweryZietara deleted the additional-worker-node-pools-docs branch January 24, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants