Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance error handling #1674

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Enhance error handling #1674

merged 1 commit into from
Jan 24, 2025

Conversation

KsaweryZietara
Copy link
Contributor

Description

Changes proposed in this pull request:

  • return apiresponses.NewFailureResponse instead of Go's standard library error.

Related issue(s)
See also #952

@KsaweryZietara KsaweryZietara added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Jan 24, 2025
@KsaweryZietara KsaweryZietara self-assigned this Jan 24, 2025
@KsaweryZietara KsaweryZietara requested a review from a team as a code owner January 24, 2025 07:47
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 24, 2025
@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) January 24, 2025 07:47
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 24, 2025
@kyma-gopher-bot kyma-gopher-bot merged commit 5cd54e2 into kyma-project:main Jan 24, 2025
32 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaroslaw-pieszka jaroslaw-pieszka jaroslaw-pieszka approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

@KsaweryZietara KsaweryZietara

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KsaweryZietara @jaroslaw-pieszka @kyma-bot @kyma-gopher-bot