SOCKS over Unix sockets: Address review

kyuupichan · Apr 8, 2021 · 384337f · 384337f
1 parent ebe2f66
commit 384337f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/aiorpcx/socks.py b/aiorpcx/socks.py
@@ -276,7 +276,7 @@ def __init__(self, address, protocol, auth):
 
         auth is an authentication method to use when connecting, or None.
         '''
-        if not isinstance(address, NetAddress) and not isinstance(address, UnixAddress):
+        if not isinstance(address, (NetAddress, UnixAddress)):
             address = NetAddress.from_string(address)
         self.address = address
         self.protocol = protocol

diff --git a/aiorpcx/util.py b/aiorpcx/util.py
@@ -190,7 +190,7 @@ def __init__(self, path: str):
 
     def __eq__(self, other):
         # pylint: disable=protected-access
-        return self._path == other._path
+        return isinstance(other, UnixAddress) and self._path == other._path
 
     def __hash__(self):
         return hash((self._path))