-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): Updated mutateExistingOnPolicyUpdate documentation to include validation info #1346
Conversation
…lidation info Signed-off-by: mvaal <[email protected]>
Thanks for opening your first Pull Request here! Please check out our Contributing guidelines and confirm that you Signed off. |
Signed-off-by: mvaal <[email protected]>
Also, this documentation seems to be wrong:
From my experience, namespace is required. I can make that fix here as well if confirmed. |
Thanks for the contribution @mvaal !
Why namespace is required for targets? A target could be a cluster-wide resource. |
Hey @realshuting!
That was my use case. I was running into some error where it kept saying that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @mvaal !
Signed-off-by: mvaal <[email protected]>
I fixed a consistency issue and updated the docs to be a little more readable based on conversation found here: |
Congratulations! 🎉Great job merging your first Pull Request here! How awesome! If you are new to this project, feel free to join our Slack community. |
Related issue
Proposed Changes
Documentation around
mutateExistingOnPolicyUpdate
was not complete and I kept running into the same issue forgetting to include the mutate target. This add that additional information to the documentation.Here is the corresponding kyverno validation code: https://github.com/kyverno/kyverno/blob/43173e6c76a6381ab27b8b2979c82d265c605ccf/api/kyverno/v1/spec_types.go#L360
Checklist