Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added documentation for DeletionPropagationPolicy for cleanupPolicy a… #1426

Merged
merged 14 commits into from
Dec 4, 2024
Merged

Added documentation for DeletionPropagationPolicy for cleanupPolicy a… #1426

merged 14 commits into from
Dec 4, 2024

Conversation

ShivamJha2436
Copy link
Contributor

…nd TTL-based cleanup resources

Related issue

This PR is a draft and needs further discussion with maintainers. No specific issue has been linked yet.

Proposed Changes

This PR includes the following updates:

  1. Expanded information on Cleanup Policies to provide more details on ClusterCleanupPolicy and CleanupPolicy types.
  2. Added explanations on the deletionPropagationPolicy options for both cleanup policies and TTL-based cleanup labels, highlighting Foreground, Background, and Orphan options.

Checklist

  • [] I have read the contributing guidelines.
  • [] I have inspected the website preview for accuracy.
  • [] I have signed off my issue.

@ShivamJha2436
Added documentation for DeletionPropagationPolicy for cleanupPolicy a…
56f784d 
…nd TTL-based cleanup resources

Signed-off-by: ShivamJha2436 <[email protected]>
@welcome Welcome
Copy link

welcome bot commented Nov 5, 2024

Thanks for opening your first Pull Request here! Please check out our Contributing guidelines and confirm that you Signed off.

@ShivamJha2436
Updated the doc
c0a774e 
Signed-off-by: ShivamJha2436 <[email protected]>
@eddycharly eddycharly marked this pull request as ready for review November 25, 2024 10:55
vishal-chdhry
vishal-chdhry requested changes Nov 25, 2024
View reviewed changes
content/en/docs/writing-policies/cleanup.md Outdated Show resolved Hide resolved
content/en/docs/writing-policies/cleanup.md Outdated Show resolved Hide resolved
@ShivamJha2436
Updated the doc
49a21ee 
Signed-off-by: ShivamJha2436 <[email protected]>
@ShivamJha2436
Fix minor changes
632b3d1 
Signed-off-by: ShivamJha2436 <[email protected]>
@ShivamJha2436
Minor changes in ttl
5fb8659 
Signed-off-by: ShivamJha2436 <[email protected]>
@ShivamJha2436
fix/doc
4dbf0cc 
Signed-off-by: ShivamJha2436 <[email protected]>
ShivamJha2436 and others added 3 commits November 26, 2024 14:01
@ShivamJha2436
fix/doc
f5e587b 
Signed-off-by: ShivamJha2436 <[email protected]>
@ShivamJha2436
made a small fix
d7364e0 
Signed-off-by: ShivamJha2436 <[email protected]>
@eddycharly
finalise doc
9124ea0 
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
@eddycharly
review comment
352a38f 
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
@vishal-chdhry vishal-chdhry merged commit be7519f into kyverno:main Dec 4, 2024
5 of 6 checks passed
@welcome Welcome
Copy link

welcome bot commented Dec 4, 2024

Congratulations! 🎉

Great job merging your first Pull Request here! How awesome! If you are new to this project, feel free to join our Slack community.

200w

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishal-chdhry vishal-chdhry vishal-chdhry approved these changes

@eddycharly eddycharly Awaiting requested review from eddycharly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShivamJha2436 @eddycharly @vishal-chdhry