-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(CI/CD): Add pr-image-builder workflow #54
Conversation
@rg0now As stated the current image format is |
The Docker image for this pull request (#54) has been successfully built and pushed to DockerHub as |
Nice work! See some minor comments in the code. Two additional things: 1) IMHO, using a new registry for PR builds requires extra effort from the users, and the missing Note: we should disable docker build/push actions in forks |
Thx, I like this. Minor wishlist item: is there any chance to garbage-collect the image at dockerhub once a PR is closed? |
@levaitamas @rg0now Garbage collection is a good idea. I will add it. |
* workflow name * keep it from running in all forks * FQ name in the comment
The Docker image for this pull request (#54) has been successfully built and pushed to DockerHub as |
The Docker image for this pull request (#54) has been successfully built and pushed to DockerHub as |
1 similar comment
The Docker image for this pull request (#54) has been successfully built and pushed to DockerHub as |
Testing garbage collection |
Garbage collection tag results in 401. Need to figure out the issue with it and need to evaluate the response code properly. |
The Docker image for this pull request (#54) has been successfully built and pushed to DockerHub as |
2 similar comments
The Docker image for this pull request (#54) has been successfully built and pushed to DockerHub as |
The Docker image for this pull request (#54) has been successfully built and pushed to DockerHub as |
Garbage collection is fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @davidkornel!
The Docker image for this pull request (#54) has been successfully built and pushed to DockerHub as |
This PR adds a workflow that builds a Docker image based on the pull requests. It gets triggered on additional commits also.
The image naming is
l7mp/stunner-gateway-operator:pr-<pr-number>
.The workflow comments on the PR with the built image name to notify the user.
Currently, the run unit test job is disabled, might be useful to enable it later.