Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: preventing sharing of auto-mounted folders #2374

Merged
merged 1 commit into from
Apr 29, 2024
Merged

fix: preventing sharing of auto-mounted folders #2374

merged 1 commit into from
Apr 29, 2024

Conversation

ironAiken2
Copy link
Contributor

@ironAiken2 ironAiken2 commented Apr 26, 2024 •
edited
Loading

This PR Resolves #2373 Issue.

Feature

auto mounted folder is a folder that name begins with '.' in the folder name. I added folder name validation to the isSharingAllowed validation logic in the control button lander logic.

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@ironAiken2 ironAiken2 requested review from yomybaby and lizable April 26, 2024 07:56
@github-actions github-actions bot added the size:XS ~10 LoC label Apr 26, 2024
@ironAiken2 ironAiken2 mentioned this pull request Apr 29, 2024
Closed
lizable
lizable approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@lizable lizable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yomybaby yomybaby merged commit 754e4a9 into main Apr 29, 2024
6 checks passed
@yomybaby yomybaby deleted the fix/disable-automount-folder-share branch April 29, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizable lizable lizable approved these changes

@yomybaby yomybaby Awaiting requested review from yomybaby

Assignees

@ironAiken2 ironAiken2

Labels
size:XS ~10 LoC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Let's disable automount folder share button in VFolder list
3 participants
@ironAiken2 @lizable @yomybaby