-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FR-247, FR-249): open folder explorer from session detail panel using vfolder_nodes #3052
base: main
Are you sure you want to change the base?
feat(FR-247, FR-249): open folder explorer from session detail panel using vfolder_nodes #3052
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8468084
to
61191e3
Compare
25dc6ea
to
2027255
Compare
61191e3
to
b9992c8
Compare
bd937d4
to
4159954
Compare
4159954
to
1b61f9a
Compare
b9992c8
to
9c53670
Compare
1b61f9a
to
6510b79
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 4.9% (-0% 🔻) |
398/8120 |
🔴 | Branches | 4.24% (-0% 🔻) |
239/5639 |
🔴 | Functions | 2.95% (-0% 🔻) |
78/2645 |
🔴 | Lines | 4.82% (-0% 🔻) |
383/7945 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 6510b79
if (this.isManagerVersionCompatibleWith('25.2.0')) { | ||
this._features['vfolder-node'] = true; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove this.
); | ||
}, | ||
)} | ||
{baiClient.supports('vfolder-nodes') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just check it using session.vfolder_nodes
. If it support it should be not undefined.
{baiClient.supports('vfolder-nodes') | |
{session.vfolder_nodes !== undefined |
resolves #3051 (FR-249)
This PR makes folder explorer available in the Session Detail Panel.
In versions after to Backend.AI Core 24.12.0, the vfolder_nodes field is provided.
Feature:
How to test:
image_node
andvfolder_node
fields toComputeSession
schema backend.ai#2987Checklist: (if applicable)