Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FR-247, FR-249): open folder explorer from session detail panel using vfolder_nodes #3052

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ironAiken2
Copy link
Contributor

@ironAiken2 ironAiken2 commented Jan 20, 2025

resolves #3051 (FR-249)

lablup/backend.ai#2987 PR must be merged first.

This PR makes folder explorer available in the Session Detail Panel.

In versions after to Backend.AI Core 24.12.0, the vfolder_nodes field is provided.

Feature:

  • allow to open folder explorer in session detail panel

How to test:

Checklist: (if applicable)

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link
Contributor Author

ironAiken2 commented Jan 20, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ironAiken2 ironAiken2 changed the title feat: open folder explorer from session detail panel using vfolder_nodes feat(FR-249): open folder explorer from session detail panel using vfolder_nodes Jan 20, 2025
@ironAiken2 ironAiken2 marked this pull request as ready for review January 20, 2025 05:52
@ironAiken2 ironAiken2 changed the title feat(FR-249): open folder explorer from session detail panel using vfolder_nodes feat(FR-247, FR-249): open folder explorer from session detail panel using vfolder_nodes Jan 20, 2025
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ironAiken2 ironAiken2 force-pushed the feat/open-folder-explorer-from-session-detail-panel branch from 8468084 to 61191e3 Compare January 23, 2025 09:54
@ironAiken2 ironAiken2 force-pushed the feat/open-folder-explorer-in-session-detail-panel-using-vfolder-nodes branch from 25dc6ea to 2027255 Compare January 23, 2025 10:00
@ironAiken2 ironAiken2 marked this pull request as draft January 24, 2025 06:24
@ironAiken2 ironAiken2 marked this pull request as ready for review January 24, 2025 06:49
@ironAiken2 ironAiken2 force-pushed the feat/open-folder-explorer-from-session-detail-panel branch from 61191e3 to b9992c8 Compare January 24, 2025 06:49
@ironAiken2 ironAiken2 force-pushed the feat/open-folder-explorer-in-session-detail-panel-using-vfolder-nodes branch 2 times, most recently from bd937d4 to 4159954 Compare January 24, 2025 07:14
@yomybaby yomybaby changed the base branch from feat/open-folder-explorer-from-session-detail-panel to graphite-base/3052 January 24, 2025 10:02
@yomybaby yomybaby force-pushed the feat/open-folder-explorer-in-session-detail-panel-using-vfolder-nodes branch from 4159954 to 1b61f9a Compare January 24, 2025 10:04
@yomybaby yomybaby changed the base branch from graphite-base/3052 to main January 24, 2025 10:05
@yomybaby yomybaby force-pushed the feat/open-folder-explorer-in-session-detail-panel-using-vfolder-nodes branch from 1b61f9a to 6510b79 Compare January 24, 2025 10:05
Copy link

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
4.9% (-0% 🔻)
398/8120
🔴 Branches
4.24% (-0% 🔻)
239/5639
🔴 Functions
2.95% (-0% 🔻)
78/2645
🔴 Lines
4.82% (-0% 🔻)
383/7945

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 6510b79

Comment on lines +740 to +742
if (this.isManagerVersionCompatibleWith('25.2.0')) {
this._features['vfolder-node'] = true;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this.

);
},
)}
{baiClient.supports('vfolder-nodes')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just check it using session.vfolder_nodes. If it support it should be not undefined.

Suggested change
{baiClient.supports('vfolder-nodes')
{session.vfolder_nodes !== undefined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:lib Library and SDK related issue. size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link the VFolder name to open the Folder Explorer in Session detail Panel
3 participants