Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FR-453): UserDropdownMenu isn't opening #3085

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Feb 3, 2025

resolves #3083 (FR-453)

Fixed a dropdown menu bug in the user profile button by wrapping the button content in a div element. This resolves an issue with the dropdown functionality when using ReverseThemeProvider in the current Ant Design version.

The fix removes the manual open state management that was previously implemented, allowing the dropdown to use its default behavior while maintaining proper functionality.

Copy link
Member Author

yomybaby commented Feb 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the size:M 30~100 LoC label Feb 3, 2025
@yomybaby yomybaby changed the title fix: UserDropdownMenu isn't opening fix(FR-453): UserDropdownMenu isn't opening Feb 3, 2025
Copy link

github-actions bot commented Feb 3, 2025

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
4.91% (+0% 🔼)
398/8113
🔴 Branches 4.24% 239/5636
🔴 Functions
2.95% (+0% 🔼)
78/2641
🔴 Lines
4.82% (+0% 🔼)
383/7938

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from d88ffa8

@yomybaby yomybaby marked this pull request as ready for review February 3, 2025 09:24
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yomybaby yomybaby force-pushed the fix/user-dropdown-menu-not-open branch 3 times, most recently from 82fc883 to ce4e0fd Compare February 3, 2025 10:54
Copy link

graphite-app bot commented Feb 3, 2025

Merge activity

resolves #3083 (FR-453)

Fixed a dropdown menu bug in the user profile button by wrapping the button content in a `div` element. This resolves an issue with the dropdown functionality when using `ReverseThemeProvider` in the current Ant Design version.

The fix removes the manual open state management that was previously implemented, allowing the dropdown to use its default behavior while maintaining proper functionality.
@graphite-app graphite-app bot force-pushed the fix/user-dropdown-menu-not-open branch from ce4e0fd to d88ffa8 Compare February 3, 2025 11:46
@graphite-app graphite-app bot merged commit d88ffa8 into main Feb 3, 2025
6 checks passed
@graphite-app graphite-app bot deleted the fix/user-dropdown-menu-not-open branch February 3, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M 30~100 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The UserDropdownMenu isn't opening
3 participants