Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: sync .sealos workdir #3903

Merged
merged 1 commit into from
Sep 24, 2023
Merged

feature: sync .sealos workdir #3903

merged 1 commit into from
Sep 24, 2023

Conversation

ghostloda
Copy link
Collaborator

support #3859

@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 932
✅ Successful 392
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 539
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@@ -273,3 +268,30 @@ func (c *Applier) deleteCluster() error {
logger.Info("succeeded in deleting current cluster")
return nil
}

func (c *Applier) syncWorkdir() {
workDir := constants.ClusterDir(c.ClusterDesired.Name)
Copy link
Collaborator

@cuisongliu cuisongliu Sep 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if exec sealos user is root and other node user name is not root , same this dir not using all nodes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes !,it should be ~/. sealos/.

Copy link
Collaborator Author

@ghostloda ghostloda Sep 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if exec sealos user is root and other node user name is not root , same this dir not using all nodes.

I'll make some modifications to this code

@cuisongliu cuisongliu changed the title feature: sync workdir feature: sync .sealos workdir Sep 12, 2023
@cuisongliu cuisongliu added this to the v4.4 milestone Sep 24, 2023
@cuisongliu cuisongliu merged commit fc2c8d0 into labring:main Sep 24, 2023
@sealos-ci-robot
Copy link
Member

/cherry-pick release-v4.4

@sealos-ci-robot
Copy link
Member

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/labring/sealos/actions/runs/6289801001

sealos-ci-robot pushed a commit that referenced this pull request Sep 24, 2023
cuisongliu pushed a commit that referenced this pull request Sep 24, 2023
bxy4543 pushed a commit to bxy4543/sealos that referenced this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants