fix: update phoenix_analytics path in Mix.install #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the path of phoenix_analytics from a relative external path to the local directory to ensure proper dependency loading.
|
Thank you for your contribution @cbuctok ! Since you are on that topic, could you please add There is a plan to build nice dev environment if this library will pick up. |
|
Thanks for the feedback! I'll go ahead and add |
Add `ip: {0, 0, 0, 0}` to endpoint_options
lalabuy948
reviewed
Sep 10, 2024
| @@ -1,7 +1,7 @@ | |||
| #!/usr/bin/env elixir | |||
| Mix.install([ | |||
| {:phoenix_playground, "~> 0.1.5"}, | |||
| {:phoenix_analytics, path: "../phoenix_analytics", force: true} | |||
| {:phoenix_analytics, path: ".", force: true} | |||
|
@cbuctok you can target 0.1.2 for this one as well! |
lalabuy948
added a commit
that referenced
this pull request
Sep 10, 2024
* fix: router conflict with error tracker (#4) * fix: Router conflict with ErrorTracker Moved `parse_options/2` into `phoenix_analytics_dashboard` macro --------- Co-authored-by: Greg Evseev <[email protected]> * version bump * fix: update phoenix_analytics path in Mix.install (#3) * fix: update phoenix_analytics path in Mix.install Changed the path of phoenix_analytics from a relative external path to the local directory to ensure proper dependency loading. Add `ip: {0, 0, 0, 0}` to endpoint_options --------- Co-authored-by: Greg Evseev <[email protected]> --------- Co-authored-by: Greg <[email protected]> Co-authored-by: Greg Evseev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the path of phoenix_analytics from a relative external path to the local directory to ensure proper dependency loading.