-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(l2): automate flamegraph tests #1366
Open
dsocolobsky
wants to merge
49
commits into
main
Choose a base branch
from
automate-perf-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsocolobsky
force-pushed
the
automate-perf-tests
branch
5 times, most recently
from
December 2, 2024 14:03
4b9b05a
to
45b74ad
Compare
dsocolobsky
force-pushed
the
automate-perf-tests
branch
from
December 2, 2024 14:05
45b74ad
to
441fc6a
Compare
dsocolobsky
force-pushed
the
automate-perf-tests
branch
3 times, most recently
from
December 2, 2024 15:49
8df6f77
to
56dccda
Compare
dsocolobsky
force-pushed
the
automate-perf-tests
branch
17 times, most recently
from
December 2, 2024 20:29
d6742e6
to
2d9e8fd
Compare
dsocolobsky
force-pushed
the
automate-perf-tests
branch
from
December 6, 2024 20:24
88c66f9
to
dbec9c7
Compare
dsocolobsky
temporarily deployed
to
github-pages
December 6, 2024 20:43 — with
GitHub Actions
Inactive
add a custom command that gets the balance in ether
|
I've added a command to get the balance: ethrex/cmd/ethrex_l2/src/commands/info.rs Line 33 in f55c741
and i've set the datetime to GMT-3:
|
…nto automate-perf-tests
fborello-lambda
temporarily deployed
to
github-pages
January 8, 2025 20:24 — with
GitHub Actions
Inactive
fborello-lambda
temporarily deployed
to
github-pages
January 8, 2025 22:08 — with
GitHub Actions
Inactive
fborello-lambda
force-pushed
the
automate-perf-tests
branch
3 times, most recently
from
January 9, 2025 13:13
23e3b49
to
1f90b69
Compare
fborello-lambda
force-pushed
the
automate-perf-tests
branch
from
January 9, 2025 13:50
1f90b69
to
3cca963
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to generate flamegraphs both for
ethrex
and forreth
on each push to main, and then be able to view them in github pages or similar.You can see the flamegraphs at https://lambdaclass.github.io/ethrex/
Description
ethrex_l2
CLI was modified to be able to create a default config non-interactively withethrex_l2 config create default --default
since the interactive CLI was not working in Github CI.ethrex_l2 test load
was modified so that it now retries when it can't connect to the server instead of failing directly, this was needed to run the test in Github CI.test_data/genesis-load-test.json
was modified to add balance to a test account, since the tests were failing sometimes otherwise.make flamegraph
locally to run the same scripts locally to generate the Ethrex flamegraphs (not the Reth ones).Notes
inferno-collapse-perf
plusinferno-flamegraph
separately because of a bug inperf
with Github CI where it would output garbage to the stdout instead of the actual perf data to aperf.data
file.Things that we should fix/check
perf script
with the--no-inline
option, since it takes a very long time without it, maybe we're not getting the proper data because of that.Other possible improvements
.png
files as preview since the.svg
look cropped there.scripts/flamegraph.sh
and.github/scripts/flamegraph_watcher.sh
and very similar and they could be merged into one, however I hardcoded some CI-paths in the latter one.