Return error message in ForkChoice.on_block

lambdaclass · Jun 4, 2024 · c695b65 · c695b65
1 parent 5b1c27b
commit c695b65
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/lib/lambda_ethereum_consensus/beacon/pending_blocks.ex b/lib/lambda_ethereum_consensus/beacon/pending_blocks.ex
@@ -193,8 +193,16 @@ defmodule LambdaEthereumConsensus.Beacon.PendingBlocks do
 
   defp process_block(state, block_info) do
     case ForkChoice.on_block(block_info) do
-      :ok -> state |> Map.delete(block_info.root)
-      :error -> state |> Map.put(block_info.root, {nil, :invalid})
+      :ok ->
+        state |> Map.delete(block_info.root)
+
+      {:error, reason} ->
+        Logger.error("[PendingBlocks] Saving block as invalid #{reason}",
+          slot: block_info.signed_block.message.slot,
+          root: block_info.root
+        )
+
+        state |> Map.put(block_info.root, {nil, :invalid})
     end
   end
 

diff --git a/lib/lambda_ethereum_consensus/fork_choice/fork_choice.ex b/lib/lambda_ethereum_consensus/fork_choice/fork_choice.ex
@@ -35,7 +35,7 @@ defmodule LambdaEthereumConsensus.ForkChoice do
     persist_store(store)
   end
 
-  @spec on_block(BlockInfo.t()) :: :ok | :error
+  @spec on_block(BlockInfo.t()) :: :ok | {:error, String.t()}
   def on_block(%BlockInfo{} = block_info) do
     store = fetch_store!()
     slot = block_info.signed_block.message.slot
@@ -67,7 +67,7 @@ defmodule LambdaEthereumConsensus.ForkChoice do
 
       {:error, reason} ->
         Logger.error("[Fork choice] Failed to add block: #{reason}", slot: slot, root: block_root)
-        :error
+        {:error, reason}
     end
   end