Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add blocks node graph #1215

Merged
merged 19 commits into from
Jul 15, 2024
Merged

feat: add blocks node graph #1215

merged 19 commits into from
Jul 15, 2024

Conversation

avilagaston9
Copy link
Contributor

@avilagaston9 avilagaston9 commented Jul 11, 2024 •
edited
Loading

  • This PR adds a Grafana node graph with:
    • Nodes: The Blocks.
    • Edges: Their relationships.
    • Colors: Their statuses:
      • Red: :invalid.
      • Orange: :download.
      • Yellow: :download_blobs.
      • Green: :pending.
      • Blue: :transitioned.
Pasted image 20240712173924
  • As a bonus, it also adds an async download if a parent block is missing, since we noticed the following behavior with the Node Graph:
image

Closes #1196
Closes #1216

@avilagaston9 avilagaston9 changed the title Node graph feat: add blocks node graph Jul 11, 2024
@avilagaston9 avilagaston9 marked this pull request as ready for review July 12, 2024 21:38
@avilagaston9 avilagaston9 requested a review from a team as a code owner July 12, 2024 21:38
Arkenan
Arkenan approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@Arkenan Arkenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/lambda_ethereum_consensus/beacon/pending_blocks.ex Outdated
Blocks.add_block_to_download(parent_root)

BlockDownloader.request_blocks_by_range(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it better to ask for request_block_by_root? Because potentially there could be more than 1 for that slot.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally. My bad, I didn't see that one. Thank you!!

@avilagaston9 avilagaston9 merged commit e417f74 into main Jul 15, 2024
19 checks passed
@avilagaston9 avilagaston9 deleted the node-graph branch July 15, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arkenan Arkenan Arkenan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Lambda Ethereum Consensus Node
Status: Done
Milestone
No milestone
2 participants
@avilagaston9 @Arkenan