feat(bench): add ec criterion benches for bls12_377 and bls12_381 #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #677 +/- ##
==========================================
- Coverage 94.40% 94.38% -0.03%
==========================================
Files 148 148
Lines 34118 34118
==========================================
- Hits 32210 32201 -9
- Misses 1908 1917 +9 ☔ View full report in Codecov by Sentry. |
PatStiles
force-pushed
the
feat/curve_bench
branch
2 times, most recently
from
34b2860 to
74e3126
Compare
PatStiles
force-pushed
the
feat/curve_bench
branch
from
c019fab to
a52de63
Compare
PatStiles
force-pushed
the
feat/curve_bench
branch
from
3c9b1a5 to
7a6a027
Compare
PatStiles
force-pushed
the
feat/curve_bench
branch
from
3e77b54 to
1702898
Compare
PatStiles
force-pushed
the
feat/curve_bench
branch
from
65d4774 to
9138279
Compare
|
There are a lot of #[allow(dead_code)], they shouldn't be needed in public functions |
PatStiles
force-pushed
the
feat/curve_bench
branch
from
5a3ce4c to
e41ec10
Compare
|
@MauroToscano removed. clippy flagged the function headers for the individual *_elliptic_curve_benchmarks so I did not remove them. |
PatStiles
force-pushed
the
feat/curve_bench
branch
from
04a3534 to
04a63ed
Compare
MauroToscano
approved these changes
Mar 6, 2024
MauroToscano
approved these changes
Mar 6, 2024
diegokingston
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TITLE
Description
Expand ec criterion benches.
Type of change
Checklist