Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unwraps on options for sync rpc response #10

Closed

Conversation

mFragaBA
Copy link
Collaborator

@mFragaBA mFragaBA commented Jan 5, 2024

addresses #51 from forked repo

Note: on e2b7bd5 I used clippy with:

cargo clippy -- -D clippy::nursery -D clippy::all -D clippy::complexity -A clippy::use_self

and found out:

  • a few functions that could be turned into const functions
  • a few redundant clones and to_string

@mFragaBA mFragaBA changed the title M fraga ba remove unwraps on options for sync rpc response remove unwraps on options for sync rpc response Jan 8, 2024
@mFragaBA mFragaBA force-pushed the mFragaBA-remove-unwraps-on-options-for-sync-rpc-response branch from 7bb2253 to ba15858 Compare January 8, 2024 13:53
@mFragaBA mFragaBA force-pushed the mFragaBA-remove-unwraps-on-options-for-sync-rpc-response branch from ba15858 to e3a2e00 Compare January 8, 2024 15:42
@mFragaBA mFragaBA marked this pull request as ready for review January 8, 2024 15:54
I only left the ones I think might be used in a const setting in the future.
…aBA-remove-unwraps-on-options-for-sync-rpc-response
…aBA-remove-unwraps-on-options-for-sync-rpc-response
@mFragaBA
Copy link
Collaborator Author

closing as I opened the same PR pointing to the forked repo

@mFragaBA mFragaBA closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant