Fix get_account_ids
#11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igamigo
reviewed
Jan 11, 2024
src/store/accounts.rs
Outdated
| .expect("no binding parameters used in query") | ||
| .map(|result| { | ||
| result | ||
| .map_err(StoreError::ColumnParsingError) | ||
| .map(|id: u64| AccountId::try_from(id).expect("account id is valid")) | ||
| .map(|id: i64| AccountId::try_from(id as u64).expect("account id is not valid")) |
There was a problem hiding this comment.
Just to be clear, in the Miden projects (not sure but it could be the norm as well) the expect() messages is usually why you expect the statement to be valid. For instance:
let timestamp = SystemTime::now()
.duration_since(UNIX_EPOCH)
.expect("we are after 1970")
.as_millis() as u64;
There was a problem hiding this comment.
Oh, I thought it was a typo. Thanks for the clarification
igamigo
reviewed
Jan 11, 2024
src/store/accounts.rs
Outdated
Comment on lines
98
to
101
| .query_map([], |row| { | ||
| let row: i64 = row.get(0)?; | ||
| Ok(row) | ||
| }) |
There was a problem hiding this comment.
I think these changes can be removed since id will be inferred to be i64 because of the following map
There was a problem hiding this comment.
you're right! I left it as it was before
…aBA-fix-endpoint-to-get-account-ids
|
closing as I opened the same PR pointing to the forked repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When testing with the cli, I found an error when running:
Changes
Rowand cast it to u64 afterwards (I saw this was being done for other ids)Steps to reproduce
It might take a few tries because it will depend on the generated faucet id. For each try do:
rm target/release/store.sqlite3 cargo run --release --features testing -- mock-data cargo run --release --features testing -- account new fungible-faucet -t TEST -d 10 -m 10000 # It should raise here cargo run --release --features testing -- sync-state sync-state