fix: MASM debug logs #17
Conversation
| @@ -549,7 +549,8 @@ impl<R: FeltRng> Client<R> { | |||
| where | |||
| T: IntoIterator<Item = (Word, Vec<Felt>)>, | |||
| { | |||
| TransactionScript::compile(program, inputs, TransactionKernel::assembler()) | |||
| let assembler = TransactionKernel::assembler().with_debug_mode(self.in_debug_mode); | |||
There was a problem hiding this comment.
Alternatively, could we instantiate by checking if TransactionExecutor is using debug mode instead of keeping a variable in the Client?
There was a problem hiding this comment.
At the moment there is no public method on the TransactionExecutor to check the debug mode, so this would require changes on miden-base. Should we make those changes?
TomasArrachea
force-pushed
the
tomasarrachea-masm-logs-from-client
branch
2 times, most recently
from
2a5f6bc to
39d6a75
Compare
| @@ -28,7 +28,9 @@ required-features = ["testing", "concurrent"] | |||
|
|
|||
| [dev-dependencies] | |||
| assert_cmd = { version = "2.0" } | |||
| predicates = { version = "3.0" } | |||
There was a problem hiding this comment.
Is this used only for the contains()? If so, I think we could remove this and do the check manually, no?
There was a problem hiding this comment.
The assert_cmd stdout method expects a predicates_core::Predicate object, so I don't think there is an easy way of testing it manually without using the predicates crate
| @@ -0,0 +1 @@ | |||
| pub mod common; | |||
There was a problem hiding this comment.
Let's add a comment here saying that we export utility functions to use in different crates
tests/Cargo.toml
Outdated
| uuid = { version = "1.10", features = ["serde", "v4"] } | ||
| toml = { version = "0.8" } |
There was a problem hiding this comment.
We should switch these so that they are in alphabetical order
We should probably have a single private Client function that creates the assembler for all scenarios so that we don't miss anything in the future |
TomasArrachea
force-pushed
the
tomasarrachea-masm-logs-from-client
branch
from
549786b to
c869a1c
Compare
TomasArrachea
force-pushed
the
tomasarrachea-masm-logs-from-client
branch
from
c869a1c to
41887a8
Compare
TomasArrachea
force-pushed
the
tomasarrachea-masm-logs-from-client
branch
from
41887a8 to
49792f5
Compare
No description provided.